Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect dark mode for PPResume PWA #52

Open
xiaohanyu opened this issue May 16, 2024 · 0 comments
Open

feat: respect dark mode for PPResume PWA #52

xiaohanyu opened this issue May 16, 2024 · 0 comments
Assignees
@xiaohanyu
Labels
feat New feature or request frontend Frontend related

Comments

@xiaohanyu
Copy link
Member

xiaohanyu commented May 16, 2024 •
edited
Loading

Description

PPResume PWA right now does not respect system dark mode as theme_color and background_color in manifest are fixed.

w3c issue: w3c/manifest#975

Stackoverflow got a workaround, which may worth a try.

Related issue: #55

[Optional] Possible Solutions

NA

Acceptance Criteria

  • the title bar, window background color should respect OS's dark mode.

Todo list

NA
@xiaohanyu xiaohanyu self-assigned this May 16, 2024
@xiaohanyu xiaohanyu added feat New feature or request frontend Frontend related labels May 16, 2024
@xiaohanyu xiaohanyu mentioned this issue May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaohanyu xiaohanyu

Labels
feat New feature or request frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiaohanyu