Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: PPResume got black title bar on mobiles which looks ugly #53

Closed
xiaohanyu opened this issue May 16, 2024 · 1 comment
Closed

bug: PPResume got black title bar on mobiles which looks ugly #53

xiaohanyu opened this issue May 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working feat New feature or request

Comments

@xiaohanyu
Copy link
Member

xiaohanyu commented May 16, 2024

Description

PPResume PWA right now has a black title bar on desktop and mobiles, while on desktops is looks OK, however, on mobiles it looks quite ugly.

To fix this from bottom up, we need to enable PPResume PWA respect dark mode #52, however, before we support dark mode, let's just make title bar (theme_color in manifest) the same as in <HeroSection>.

To Reproduce

Install and open PPResume PWA on Android or iOS, and then you will get a black title bar because we set "theme_color": "#202020" in manifest.

Actual Behavior

Image

Expected Behavior

Image

[Optional] Screenshots

NA

Desktop

NA

Smartphone

  • Device: iPhone 12 Pro Max simulator
  • OS: iOS 15.5
  • Browser: Safari
  • Version: NA

Additional Context

NA

@xiaohanyu xiaohanyu self-assigned this May 16, 2024
@xiaohanyu xiaohanyu added bug Something isn't working feat New feature or request labels May 16, 2024
@xiaohanyu
Copy link
Member Author

Fixed:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant