Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyboards implementation. #1224

Merged
merged 21 commits into from
Sep 14, 2017
Merged

Storyboards implementation. #1224

merged 21 commits into from
Sep 14, 2017

Conversation

Damnae
Copy link
Contributor

@Damnae Damnae commented Sep 8, 2017

No description provided.

@peppy
Copy link
Sponsor Member

peppy commented Sep 8, 2017

Getting a crash on https://osu.ppy.sh/s/8023:

windows_10

@Damnae
Copy link
Contributor Author

Damnae commented Sep 8, 2017

Fixed it.

I also implemented loops, but since adding transforms removes transforms on the same property that come later, it probably won't work everywhere...

@Damnae
Copy link
Contributor Author

Damnae commented Sep 11, 2017

Should be ready to be reviewed. I left triggers, samples and integrating it with the game for later, but all storyboards I tested were working (~30).

@peppy
Copy link
Sponsor Member

peppy commented Sep 13, 2017

I'd consider renaming:
StoryboardDefinitionStoryboard
StoryboardDrawableStoryboard
as this is more in line with the rest of our model/view representations.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@peppy peppy merged commit 307a709 into ppy:master Sep 14, 2017
@peppy
Copy link
Sponsor Member

peppy commented Sep 14, 2017

@Damnae Let me know if you're interested in a bounty for this PR. The scale and implementation quality is definitely worthy of compensation.

@Damnae
Copy link
Contributor Author

Damnae commented Sep 14, 2017

@peppy That would be great, thanks!

@peppy
Copy link
Sponsor Member

peppy commented Sep 14, 2017

Awarding $800 in bounty for this. Contact me via email with a paypal account (or osu! supporter tags or whatever if you'd prefer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants