Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disclaimer #13727

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Update disclaimer #13727

merged 4 commits into from
Jul 2, 2021

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 1, 2021

No description provided.

@bdach
Copy link
Collaborator

bdach commented Jul 1, 2021

Not super sure about this one. The very first time I saw this disclaimer play out I wasn't sure what it meant to say, and even thought it was possibly buggy for a second. I think the way I'm supposed to be interpreting the animation is that it's "correcting the wrong thinking" that lazer "isn't osu!"? But the text post-logo-bounce-and-change just feels difficult to understand...

Maybe it should say "This is the next major update to osu!" (single-line) rather than "This is osu! / the next major update"? Or just drop the text change? Dunno, something about the text change and the phrasing just throws me off ever so slightly...

@peppy
Copy link
Sponsor Member Author

peppy commented Jul 1, 2021

It's intended to throw people off, so it's good to know that's what you take away from it ;).

We will start to drop the term "lazer" altogether; this is a first step.

Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

@smoogipoo smoogipoo merged commit ace57a9 into ppy:master Jul 2, 2021
@peppy peppy deleted the update-disclaimer branch July 2, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants