-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate adjustment settings for all time mods (DT/HT/NC/DC/WU/WD) #7121
Conversation
How would these mods be ranked/scored then? It makes sense to be ranked only at default rate, but that requires some more mechanism. |
No idea. Ranking is not a consideration yet. |
Test failure fixed in ppy/osu-framework#3095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
One thing I noticed is that if you enable DT then exit song select and go back in, the customise button will be greyed out. |
I encountered 2 bugs with this branch.
Spoiler2019-12-13 00:13:16: Unhandled exception has been allowed with 0 more allowable exceptions . |
cc68127
to
59538bf
Compare
@l3lackShark the second (crash) bug has been fixed via dependent PRs. The jump in speed may still exist, but can be addressed elsewhere. after this is merged into master, please open an issue if it still occurs! |
Resolves #7162.