Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate adjustment settings for all time mods (DT/HT/NC/DC/WU/WD) #7121

Merged
merged 23 commits into from
Dec 13, 2019

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Dec 9, 2019

@huoyaoyuan
Copy link
Contributor

How would these mods be ranked/scored then? It makes sense to be ranked only at default rate, but that requires some more mechanism.

@peppy
Copy link
Sponsor Member Author

peppy commented Dec 9, 2019

No idea. Ranking is not a consideration yet.

@peppy
Copy link
Sponsor Member Author

peppy commented Dec 11, 2019

Test failure fixed in ppy/osu-framework#3095

smoogipoo
smoogipoo previously approved these changes Dec 11, 2019
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smoogipoo
Copy link
Contributor

One thing I noticed is that if you enable DT then exit song select and go back in, the customise button will be greyed out.

@peppy
Copy link
Sponsor Member Author

peppy commented Dec 12, 2019

Once #7172 is merged, I will rebase this PR, removing the #7170 commits and using #7172 logic instead.

@l3lackShark
Copy link

I encountered 2 bugs with this branch.

  1. Approach circle of the first note makes "jumps" in speed when the speed multiplier is applied.
  2. Several beatmaps crash on transition to gameplay, including this one: https://osu.ppy.sh/beatmapsets/659007#osu/1768802
Spoiler

2019-12-13 00:13:16: Unhandled exception has been allowed with 0 more allowable exceptions .
2019-12-13 00:13:16: An unhandled error has occurred.
2019-12-13 00:13:16: System.ArgumentNullException: Value cannot be null.
2019-12-13 00:13:16: at System.Threading.Monitor.ReliableEnter(Object obj, Boolean& lockTaken)
2019-12-13 00:13:16: at osu.Framework.Graphics.Drawable.dispose(Boolean isDisposing)
2019-12-13 00:13:16: at osu.Framework.Graphics.Drawable.Finalize()

@peppy
Copy link
Sponsor Member Author

peppy commented Dec 13, 2019

@l3lackShark the second (crash) bug has been fixed via dependent PRs. The jump in speed may still exist, but can be addressed elsewhere. after this is merged into master, please open an issue if it still occurs!

@peppy peppy merged commit a904660 into ppy:master Dec 13, 2019
@peppy peppy deleted the adjustable-rate-mods branch December 13, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mods that change clock speed are not resetting
5 participants