Skip to content

Commit

Permalink
docs: fix TODOs in api docs (envoyproxy#9504)
Browse files Browse the repository at this point in the history
Some TODOs are currently visible on the documentation (for example https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/config_source.proto.html). Moved them into a [#comment: ...] block so that they are not rendered on the documentation page.

Risk Level: low

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
  • Loading branch information
derekargueta authored and prakhag1 committed Jan 3, 2020
1 parent 3e66c8c commit ecfc1e6
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/envoy/admin/v2alpha/clusters.proto
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,6 @@ message HostHealthStatus {

// Health status as reported by EDS. Note: only HEALTHY and UNHEALTHY are currently supported
// here.
// TODO(mrice32): pipe through remaining EDS health status possibilities.
// [#comment:TODO(mrice32): pipe through remaining EDS health status possibilities.]
api.v2.core.HealthStatus eds_health_status = 3;
}
2 changes: 1 addition & 1 deletion api/envoy/admin/v3alpha/clusters.proto
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,6 @@ message HostHealthStatus {

// Health status as reported by EDS. Note: only HEALTHY and UNHEALTHY are currently supported
// here.
// TODO(mrice32): pipe through remaining EDS health status possibilities.
// [#comment:TODO(mrice32): pipe through remaining EDS health status possibilities.]
api.v3alpha.core.HealthStatus eds_health_status = 3;
}
2 changes: 1 addition & 1 deletion api/envoy/api/v2/cds.proto
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ message Cluster {
// *TransportSocketMatch* in this field. Other client Envoys receive CDS without
// *transport_socket_match* set, and still send plain text traffic to the same cluster.
//
// TODO(incfly): add a detailed architecture doc on intended usage.
// [#comment:TODO(incfly): add a detailed architecture doc on intended usage.]
repeated TransportSocketMatch transport_socket_matches = 43;

// Supplies the name of the cluster which must be unique across all clusters.
Expand Down
3 changes: 2 additions & 1 deletion api/envoy/api/v2/core/config_source.proto
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ message ApiConfigSource {
// with every update, the xDS server only sends what has changed since the last update.
//
// DELTA_GRPC is not yet entirely implemented! Initially, only CDS is available.
// Do not use for other xDSes. TODO(fredlas) update/remove this warning when appropriate.
// Do not use for other xDSes.
// [#comment:TODO(fredlas) update/remove this warning when appropriate.]
DELTA_GRPC = 3;
}

Expand Down
2 changes: 1 addition & 1 deletion api/envoy/api/v3alpha/cds.proto
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ message Cluster {
// *TransportSocketMatch* in this field. Other client Envoys receive CDS without
// *transport_socket_match* set, and still send plain text traffic to the same cluster.
//
// TODO(incfly): add a detailed architecture doc on intended usage.
// [#comment:TODO(incfly): add a detailed architecture doc on intended usage.]
repeated TransportSocketMatch transport_socket_matches = 43;

// Supplies the name of the cluster which must be unique across all clusters.
Expand Down
3 changes: 2 additions & 1 deletion api/envoy/api/v3alpha/core/config_source.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ message ApiConfigSource {
// with every update, the xDS server only sends what has changed since the last update.
//
// DELTA_GRPC is not yet entirely implemented! Initially, only CDS is available.
// Do not use for other xDSes. TODO(fredlas) update/remove this warning when appropriate.
// Do not use for other xDSes.
// [#comment:TODO(fredlas) update/remove this warning when appropriate.]
DELTA_GRPC = 3;
}

Expand Down

0 comments on commit ecfc1e6

Please sign in to comment.