only check is connected for dom nodes (#4409)

* only check is connected for dom nodes * optimize by not accessing the dom
preactjs · Jun 28, 2024 · 16aeb9f · 16aeb9f
1 parent 76f5d66
commit 16aeb9f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -116,8 +116,12 @@ export function diffChildren(
 			childVNode._flags & INSERT_VNODE ||
 			oldVNode._children === childVNode._children
 		) {
-			// @ts-expect-error olDom should be present on a DOM node
-			if (oldDom && !parentDom.contains(oldDom)) {
+			if (
+				oldDom &&
+				typeof childVNode.type == 'string' &&
+				// @ts-expect-error olDom should be present on a DOM node
+				!parentDom.contains(oldDom)
+			) {
 				oldDom = getDomSibling(oldVNode);
 			}
 			oldDom = insert(childVNode, oldDom, parentDom);