Improve comment

preactjs · Mar 20, 2023 · 5242ac0 · 5242ac0
1 parent b4df76d
commit 5242ac0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/diff/index.js b/src/diff/index.js
@@ -439,8 +439,9 @@ function diffElementNodes(
 				// Unmount any previous children
 				if (oldVNode._children) {
 					while ((i = oldVNode._children.pop())) {
-						// Setting textContent on the dom element already unmounted all DOM
-						// nodes of the previous children
+						// Setting textContent on the dom element will unmount all DOM nodes
+						// of the previous children, so we don't need to remove DOM in this
+						// call to unmount
 						unmount(i, oldVNode, true);
 					}
 				}

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -1208,16 +1208,16 @@ describe('render()', () => {
 		sinon.spy(Child.prototype, 'componentDidMount');
 		sinon.spy(Child.prototype, 'componentWillUnmount');
 
-		function App({ condition = false }) {
-			return <div>{condition ? 'Hello' : [<Child />, <span>b</span>]}</div>;
+		function App({ textChild = false }) {
+			return <div>{textChild ? 'Hello' : [<Child />, <span>b</span>]}</div>;
 		}
 
 		render(<App />, scratch);
 		expect(scratch.innerHTML).to.equal('<div>Child<span>b</span></div>');
 		expect(proto.componentDidMount).to.have.been.calledOnce;
 		expect(proto.componentWillUnmount).to.have.not.been.called;
 
-		render(<App condition />, scratch);
+		render(<App textChild />, scratch);
 		expect(scratch.innerHTML).to.equal('<div>Hello</div>');
 		expect(proto.componentDidMount).to.have.been.calledOnce;
 		expect(proto.componentWillUnmount).to.have.been.calledOnce;