Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove focus from event capturing tests #4217

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Remove focus from event capturing tests #4217

merged 1 commit into from
Nov 22, 2023

Conversation

andrewiggins
Copy link
Member

Using focus as a test event for capturing is failing in some browsers (I tested Edge & Chrome). Adding timeouts seemed to fix it, but instead of trying to workaround flakiness, I'm removing focus testing as it doesn't seem necessary for this test.

This PR should get Saucelabs running green again.

Using focus as a test event for capturing is failing in some browsers (I tested Edge & Chrome). Adding timeouts seemed to fix it, but instead of trying to workaround flakiness, I'm removing focus testing as it doesn't seem necessary for this test.
@coveralls
Copy link

Coverage Status

coverage: 99.463%. remained the same
when pulling fd9f4a5 on fix-edge-tests
into d72d974 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants