Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add popover types #4378

Merged
merged 1 commit into from
May 11, 2024
Merged

feat: Add popover types #4378

merged 1 commit into from
May 11, 2024

Conversation

rschristian
Copy link
Member

Reference:


popover="hint" hasn't yet landed in the spec and as such is perhaps questionable. It seems likely that it will and I figure jumping the gun on implementation might be slightly better than needing to be pinged to add it later (as it's not a spec I'm watching), but happy to remove it if it's undesirable.

@coveralls
Copy link

Coverage Status

coverage: 99.609%. remained the same
when pulling 598765e on types/popover
into 1b4e683 on main.

@rschristian
Copy link
Member Author

rschristian commented May 10, 2024

One sec, I need to check the camel cased versions, that might be no good as the JS property is slightly different

Should be all bueno here, rts might need a fix up for the reflected attrs, depending on whether we consider that an issue

@rschristian rschristian marked this pull request as draft May 10, 2024 23:10
| 'toggle'
| undefined
| SignalLike<'hide' | 'show' | 'toggle' | undefined>;
popoverTargetAction?:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will set the property whereas popoverTarget will set the attribute due to the fact the property is actually popoverTargetElement (and takes an element reference rather than an idref string).

This mismatch might be confusing to people?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just remembered I think the property for action reflects to the content attribute so it might be fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, should actually be okay because of that.

@rschristian rschristian marked this pull request as ready for review May 10, 2024 23:17
@rschristian rschristian merged commit 6449692 into main May 11, 2024
4 checks passed
@rschristian rschristian deleted the types/popover branch May 11, 2024 05:45
@JoviDeCroock JoviDeCroock mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants