Skip to content

Commit

Permalink
Update PossibleIncorrectComparisonWithNull.md (PowerShell#733)
Browse files Browse the repository at this point in the history
* Update PossibleIncorrectComparisonWithNull.md

This is technically more accurate. PowerShell doesn't check for a $null in the array as was previously indicated.

* Update PossibleIncorrectComparisonWithNull.md

Revised description based on comments.
  • Loading branch information
KirkMunro authored and Kapil Borle committed Sep 29, 2017
1 parent fdb0499 commit 521f41c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions RuleDocumentation/PossibleIncorrectComparisonWithNull.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
To ensure that PowerShell performs comparisons correctly, the `$null` element should be on the left side of the operator.

There are a number of reasons why this should occur:
* When there is an array on the left side of a null equality comparison, PowerShell will check for a `$null` IN the array rather than if the array is null.
* PowerShell will perform type casting left to right, resulting in incorrect comparisons when `$null` is cast to other types.
* `$null` is a scalar. When the input (left side) to an operator is a scalar value, comparison operators return a Boolean value. When the input is a collection of values, the comparison operators return any matching values, or an empty array if there are no matches in the collection. The only way to reliably check if a value is `$null` is to place `$null` on the left side of the operator so that a scalar comparison is perfomed.
* PowerShell will perform type casting left to right, resulting in incorrect comparisons when `$null` is cast to other scalar types.

## How

Expand Down

0 comments on commit 521f41c

Please sign in to comment.