Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to compressed mapping #1335

Merged
merged 16 commits into from
May 16, 2024

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented May 7, 2024

Closes: #710

Untitled-2024-02-23-1901

@nichmor nichmor marked this pull request as ready for review May 7, 2024 12:22
examples/conda_mapping/test_conda_mapping.py Show resolved Hide resolved
src/lock_file/package_identifier.rs Outdated Show resolved Hide resolved
src/lock_file/package_identifier.rs Show resolved Hide resolved
src/pypi_mapping/custom_pypi_mapping.rs Outdated Show resolved Hide resolved
Comment on lines 169 to 171
if let Some(mapped_channel) = custom_mapping.get(&record.channel) {
if let Some(mapped_name) = mapped_channel.get(record.package_record.name.as_normalized()) {
if let Some(name) = mapped_name {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think you can use an if-let chain for this: rust-lang/rust#88642. Not sure, have not used it yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is saying that ``let expressions in this position are unstable
rust-lang/rust#53667

tests/solve_group_tests.rs Outdated Show resolved Hide resolved
tests/solve_group_tests.rs Outdated Show resolved Hide resolved
tests/solve_group_tests.rs Outdated Show resolved Hide resolved
src/pypi_mapping/prefix_pypi_name_mapping.rs Outdated Show resolved Hide resolved
src/pypi_mapping/prefix_pypi_name_mapping.rs Show resolved Hide resolved
@nichmor nichmor requested a review from tdejager May 15, 2024 10:02
@tdejager
Copy link
Contributor

LGTM @ruben-arts could you give it a final test tomorrow?

@ruben-arts ruben-arts merged commit 66ce6cf into prefix-dev:main May 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda-forge package and Pypi package with the same name
3 participants