fix: fix an intra-doc link failure that passed through #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
reviewed
Feb 8, 2024
| @@ -186,7 +186,7 @@ pub enum OnWheelBuildFailure { | |||
| } | |||
|
|
|||
| /// Additional options that may influence the solver. In general passing [`Default::default`] to | |||
| /// the [`resolve::resolve`] function should provide sane defaults, however if you want to fine tune the | |||
| /// the [`super::resolve`] function should provide sane defaults, however if you want to fine tune the | |||
There was a problem hiding this comment.
what is more correct one crate::resolve::resolve or super::resolve?
There was a problem hiding this comment.
Not sure, it should resolve in the rendered html. So I guess its just a user preference? I kinda like this because it symbolizes a more direct relation.
There was a problem hiding this comment.
thanks! was just curious for the future :)
nichmor
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.