chore: add Borrow impl for Extra and NormalizedPackageName #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows these types to be used in HashMaps which can be queried by string.
tdejager
approved these changes
Nov 24, 2023
baszalmstra
added a commit
to conda/rattler
that referenced
this pull request
Jan 5, 2024
Adds a `Borrow<str>` implementation for `PackageName`.
This allows indexing `HashMap`s with a `PackageName` as key with a
`str`. e.g.:
```rust
fn get_package_version(map: &HashMap<PackageName, Version>) -> Option<&Version> {
maps.get("normalized_package_name")
}
```
just works.
Previously you would have to write:
```rust
fn get_package_version(map: &HashMap<PackageName, Version>) -> Option<&Version> {
maps.get(PackageName::from_str("normalized_package_name").unwrap())
}
```
Similar to prefix-dev/rip#89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows these types to be used in HashMaps which can be queried by string.
I didnt implement it for
PackageNamebecause the hash ofPackageNameis not equal to the hash ofString.