Throw error when resolver is not an object + Better error messages when deserializing unknown nodes #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be found in resolver
resolver will never be undefined
|
Deploy preview for craftjs ready! Built with commit 4b199c0 |
|
I replaced RTL with enzyme. 👍 |
prevwong
requested changes
Nov 5, 2020
Comment on lines
77
to
84
| invariant( | ||
| (Comp !== undefined && typeof Comp === 'string' && Comp.length > 0) || | ||
| (Comp as { resolvedName?: string }).resolvedName !== undefined, | ||
| ERROR_DESERIALIZE_COMPONENT_NOT_IN_RESOLVER.replace( | ||
| '%displayName%', | ||
| data.displayName | ||
| ).replace('%availableComponents%', Object.keys(resolver).join(', ')) | ||
| ); |
There was a problem hiding this comment.
Can we break this line up so it is more readable?
Ie:
Suggested change
| invariant( | |
| (Comp !== undefined && typeof Comp === 'string' && Comp.length > 0) || | |
| (Comp as { resolvedName?: string }).resolvedName !== undefined, | |
| ERROR_DESERIALIZE_COMPONENT_NOT_IN_RESOLVER.replace( | |
| '%displayName%', | |
| data.displayName | |
| ).replace('%availableComponents%', Object.keys(resolver).join(', ')) | |
| ); | |
| const isCompHtmlElement = Comp !== undefined && typeof Comp === 'string'; | |
| const isCompUserComponent = Comp !== undefined && (Comp as { resolvedName?: string }).resolvedName !== undefined; | |
| invariant(isCompHtmlElement || isCompUserComponent, '....') |
prevwong
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay I'm back. With a smaller change this time.
This should help to prevent some common beginner mistakes.
Display an error when
resolveron<Editor />is not an objectDisplay an error which component cannot be resolved