Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dimensions behavior #134

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Add Dimensions behavior #134

merged 3 commits into from
Aug 29, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 26, 2022

This moves the Dimensions behavior from dotcom because it is required for the ActionBar component I'm currently working on in PVC primer/view_components#1339

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

🦋 Changeset detected

Latest commit: cc5bf8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/behaviors Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan marked this pull request as ready for review August 26, 2022 20:53
@jonrohan jonrohan requested review from a team, pksjce and colebemis August 26, 2022 20:53
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan jonrohan merged commit d96eb3d into main Aug 29, 2022
@jonrohan jonrohan deleted the add_dimensions branch August 29, 2022 15:55
@primer-css primer-css mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants