Skip to content

Commit

Permalink
Remove form-validation.scss (#2402)
Browse files Browse the repository at this point in the history
* Move `.form-group label`

* Remove `form-validation.scss`

* Create .changeset/poor-hotels-roll.md

* Lint
  • Loading branch information
simurai committed Mar 28, 2023
1 parent 85f31cc commit c6e214b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 267 deletions.
5 changes: 5 additions & 0 deletions .changeset/poor-hotels-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": major
---

Remove `form-validation` styles
3 changes: 2 additions & 1 deletion src/forms/form-group.scss
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
}

label {
position: relative;
// fix for chrome bug, see https://github.com/github/github/issues/53931
position: static;
}

&.flattened dt, // TODO: Deprecate
Expand Down
265 changes: 0 additions & 265 deletions src/forms/form-validation.scss

This file was deleted.

1 change: 0 additions & 1 deletion src/forms/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
@import './form-control.scss';
@import './form-select.scss';
@import './form-group.scss';
@import './form-validation.scss';
@import './input-group.scss';
@import './radio-group.scss';
// new pvc components
Expand Down

0 comments on commit c6e214b

Please sign in to comment.