Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for table border #1128

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Add support for table border #1128

merged 3 commits into from
Aug 3, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 23, 2020

This makes table inside .markdown-body adjust in width based on the content.

Before After
image image

Note: The border for table is not set and thus the "outer" border is not visible by default. But it can be enabled when using the MediaWiki format in Wikis. See #1127.

Test 👉 https://github.com/simcado/test/wiki/Table-in-MediaWiki-test


Fixes #1127

@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/3e9279kad
✅ Preview: https://primer-css-git-table-border.primer.vercel.app

Copy link
Contributor

@vdepizzol vdepizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@simurai simurai changed the base branch from master to release-15.1.0 August 3, 2020 00:26
@simurai simurai merged commit 6327af4 into release-15.1.0 Aug 3, 2020
@simurai simurai deleted the table-border branch August 3, 2020 00:26
@simurai simurai mentioned this pull request Aug 3, 2020
8 tasks
@koll051
Copy link

koll051 commented Nov 4, 2022

The width: max-content, unfortunately, breaks tables-in-tables, which are possible in AsciiDoc:

width_max-content

I would much appreciate if this could be solved (or, if this is not the right place to ask, if someone could point me in the right direction). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.markdown-body table styling
3 participants