Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .autocomplete-results inset border that is occluded by items #1152

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

neildaniels
Copy link
Contributor

Individual . autocomplete-item children of .autocomplete-results all have a background color, which completely covers the inset border.

This becomes evident if any individual items have margin overrides, or the parent results view has additional padding added.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Aug 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/pzpgc1z73
✅ Preview: https://primer-css-git-fork-neildaniels-patch-1.primer.vercel.app

@vercel vercel bot temporarily deployed to Preview August 28, 2020 02:32 Inactive
@auareyou auareyou requested a review from simurai August 28, 2020 12:02
@simurai
Copy link
Contributor

simurai commented Sep 3, 2020

@neildaniels thanks for noticing. 🙇

I can't really remember, but I think initially the intention was to show a border, but not for the .autocomplete-item when they are selected (blue background):

Screen Shot 2020-09-03 at 13 50 46

But that regressed later when we added a white background to support using <button> or <a> elements for .autocomplete-item.

Hmm.. maybe we should just add a normal border instead. Selected items will not go edge to edge, but maybe the safer option and matches the .suggester.

Screen Shot 2020-09-03 at 13 58 03

I'll commit and push straight to this branch.

@vercel vercel bot temporarily deployed to Preview September 3, 2020 05:06 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks ready to ship... 🚢 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants