Move Menlo before Consolas in monospace font stack #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c39d8a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
This does mean people on Windows who have manually installed Menlo will get that instead of Consolas, but the number of people this affects is far less than Macs with Office and Chrome.
This sounds reasonable to me. 👍
@arzg Thanks. 🙇
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Office for Mac products install a number of Microsoft fonts, including Consolas. This means that people who:
are getting all monospace text in Consolas instead of Menlo, which is the next-best choice after SF Mono for macOS.
This does mean people on Windows who have manually installed Menlo will get that instead of Consolas, but the number of people this affects is far less than Macs with Office and Chrome.
/cc @primer/ds-core