Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gatsby docs site #2484

Merged
merged 17 commits into from
Jul 13, 2023
Merged

Remove Gatsby docs site #2484

merged 17 commits into from
Jul 13, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jul 10, 2023 •
edited
Loading

What are you trying to accomplish?

  • Upgrade Storybook to v7
  • Delete Gatsby site

This should ensure that all relevant docs still exist in Storybook so they aren't lost forever.

Can these changes ship as is?

Need to merge this PR first to make sure /css redirects to Storybook primer/primer.style#369

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 945070e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank mentioned this pull request Jul 12, 2023
Merged
1 task
@langermank langermank changed the title Move all Gatsby docs to Storybook Remove Gatsby docs site Jul 12, 2023
@langermank langermank temporarily deployed to github-pages July 12, 2023 21:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 12, 2023 21:58 Inactive
@langermank langermank marked this pull request as ready for review July 12, 2023 23:25
@langermank langermank requested a review from a team as a code owner July 12, 2023 23:25
@langermank langermank temporarily deployed to github-pages July 12, 2023 23:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 12, 2023 23:28 Inactive
jonrohan
jonrohan approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo hoo 💯

@github-actions github-actions bot temporarily deployed to Storybook Preview July 13, 2023 22:04 Inactive
@langermank langermank merged commit ad358f2 into main Jul 13, 2023
12 checks passed
@langermank langermank deleted the upgrade-storybook branch July 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann was automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @jonrohan