Auto publish storybook #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
reviewed
Jun 28, 2018
script/after_success
Outdated
| # Build and publish storybook | ||
| # test. TODO: REMOVE | ||
| $(npm bin)/build-storybook -o build | ||
| $(npm bin)/gh-pages -d build -b gh-pages -r https://${GH_TOKEN}@github.com/primer/storybook |
There was a problem hiding this comment.
Minus the ${GH_TOKEN}, this looks like what we're already doing in the publish-storybook run-script. Should we update that instead?
There was a problem hiding this comment.
Wouldn't it fail because we won't have the environment variable locally?
shawnbot
reviewed
Jun 28, 2018
script/after_success
Outdated
| @@ -11,7 +11,7 @@ then | |||
| # Build and publish storybook | |||
| # test. TODO: REMOVE | |||
| $(npm bin)/build-storybook -o build | |||
| $(npm bin)/gh-pages -d build -b gh-pages -r https://${GH_TOKEN}@github.com/primer/storybook | |||
| $(npm bin)/gh-pages -d build -b gh-pages -r https://${GITHUB_AUTH}@github.com/primer/storybook | |||
There was a problem hiding this comment.
We might want to add the --silent flag here so that the auth token doesn't show up in logs if there's a failure.
|
Confirmed this works
cc @shawnbot |
19 tasks
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
I had to setup a new GH_TOKEN for this.