Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing deprecated column grid styles #662

Merged
merged 7 commits into from
Sep 10, 2019
Merged

Removing deprecated column grid styles #662

merged 7 commits into from
Sep 10, 2019

Conversation

jonrohan
Copy link
Member

This removes all the deprecated column grid styles.

  • .container
  • .column, .columns
  • one-half, etc...

@shawnbot

ref https://github.com/github/design-systems/issues/59

@shawnbot
Copy link
Contributor

Ah, @jonrohan it looks like the test failed because this removes the /objects/layout from the docs. You'll need to explicitly mark this as removed as in this change:

  '/objects/layout': removed,

@jonrohan
Copy link
Member Author

We're gonna push this PR for v12. Instead we're adding a warning #663

@jonrohan jonrohan changed the base branch from release-11.0.0 to master January 27, 2019 18:46
@shawnbot shawnbot changed the base branch from master to release-13.0.0 September 9, 2019 21:37
@shawnbot shawnbot mentioned this pull request Sep 9, 2019
Merged
15 tasks
@shawnbot
Copy link
Contributor

shawnbot commented Sep 9, 2019

FYI, I'm queueing this up for inclusion in #887 (v13.0.0). 🎉

@vercel
Copy link

vercel bot commented Sep 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-removecolumnstyles.primer.now.sh

@shawnbot shawnbot mentioned this pull request Sep 10, 2019
Merged
1 task
@vercel vercel bot temporarily deployed to staging September 10, 2019 20:28 Inactive
@shawnbot
Copy link
Contributor

As of 40bca3c, running the deprecations test script (see #889) yields:

script/test-deprecations.js
i 17 selectors removed locally (compared with latest)
i 18 selectors deprecated in v13.0.0
𐄂 ".btn-purple" deprecated, but not removed
✓ ".text-pending" is officially deprecated
✓ ".bg-pending" is officially deprecated
✓ ".container" is officially deprecated
✓ ".container::before" is officially deprecated
✓ ".container::after" is officially deprecated
✓ ".columns" is officially deprecated
✓ ".columns::before" is officially deprecated
✓ ".columns::after" is officially deprecated
✓ ".column" is officially deprecated
✓ ".one-third" is officially deprecated
✓ ".two-thirds" is officially deprecated
✓ ".one-fourth" is officially deprecated
✓ ".one-half" is officially deprecated
✓ ".three-fourths" is officially deprecated
✓ ".one-fifth" is officially deprecated
✓ ".four-fifths" is officially deprecated
✓ ".centered" is officially deprecated

I had to explicitly add ::before and ::after selectors to the deprecations list, but I wonder if it makes sense to ignore those if the "parent" selector (in this case, .container and .columns) is being deprecated? Or maybe it's just better to be explicit? 🤷‍♀

shawnbot
shawnbot approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!

@shawnbot shawnbot merged commit fbdc634 into release-13.0.0 Sep 10, 2019
@shawnbot shawnbot deleted the remove_column_styles branch September 11, 2019 18:21
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 14, 2022
Open
Open
Open
This was referenced Dec 28, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
major release Tag: Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @shawnbot