Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.0.2 #688

Merged
merged 31 commits into from
Feb 28, 2019
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0e97ea6
Explain why .tooltipped should be used sparingly
muan Feb 13, 2019
df00424
Apply suggested copy changes
dgraham Feb 14, 2019
b2048cf
docs: add redirectTrailingSlash helper
shawnbot Feb 19, 2019
3da7c50
docs: add custom _error page w/trailing slash fix
shawnbot Feb 19, 2019
0988e6e
chore: lint
shawnbot Feb 19, 2019
1f89295
docs: do one thing well in redirectTrailingSlash()
shawnbot Feb 19, 2019
5bed002
docs: get props the right way in error handler
shawnbot Feb 19, 2019
ed34ad1
chore: lint
shawnbot Feb 19, 2019
96fc429
add comment to rebuild for Now timeout
shawnbot Feb 19, 2019
efefc3c
deps: bump to @primer/components@10.0.1, sc@4.1.2
shawnbot Feb 19, 2019
80197c7
docs(error): add default statusCode (500)
shawnbot Feb 19, 2019
cdda740
docs: add static/ to "files" in now.json
shawnbot Feb 21, 2019
6b87688
Merge branch 'fix-trailing-slash' into release-12.0.2
shawnbot Feb 21, 2019
2808122
internal: remove postversion script, update release docs
shawnbot Feb 21, 2019
aefa90d
chore: v12.0.2
shawnbot Feb 21, 2019
3dd48ca
Merge remote-tracking branch 'origin/master' into tooltip
shawnbot Feb 21, 2019
91649d4
Merge pull request #676 from primer/tooltip
shawnbot Feb 21, 2019
4d8a533
new header image! :tada:
shawnbot Feb 21, 2019
f4d2cba
docs: make the README flashy, like Components’
shawnbot Feb 21, 2019
7924798
docs: add static/readme.png
shawnbot Feb 21, 2019
75b5cbe
updated README image with current version
ashygee Feb 21, 2019
045941a
Merge pull request #689 from primer/image-updates
shawnbot Feb 21, 2019
ced8730
chore: 12.0.2 changelog
shawnbot Feb 22, 2019
c2bef41
fix(marketing/utilities): add back padding utils
shawnbot Feb 27, 2019
472b2c5
Merge pull request #695 from primer/fix-marketing-utilities
shawnbot Feb 27, 2019
c57c920
update InterUI name to Inter, and update font files
gladwearefriends Feb 27, 2019
562bdf5
Merge branch 'master' into release-12.0.2
shawnbot Feb 27, 2019
ebcb391
Merge remote-tracking branch 'origin/release-12.0.2' into update-inte…
shawnbot Feb 27, 2019
e02c187
chore: update 12.0.2 changelog again
shawnbot Feb 27, 2019
5991168
Merge pull request #696 from primer/update-inter-font
shawnbot Feb 27, 2019
d93019e
chore: bump @primer/components to 11.0.0
shawnbot Feb 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Explain why .tooltipped should be used sparingly
  • Loading branch information
muan committed Feb 13, 2019
commit 0e97ea6c97cea09fd48d3995baf74f5877981460
6 changes: 5 additions & 1 deletion modules/primer-tooltips/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ Add tooltips built entirely in CSS to nearly any element.

## Implementation and accessibility

**Attention**: we use `aria-label` for tooltips instead of something like `data-tooltip` because it is crucial that the tooltip content is available for screen reader users as well. However, `aria-label` **replaces** the text content of an element for screen reader users, so only use tooltip if there is no better way to present the information, or consider using `title` for supplement information.
Tooltips as a UI pattern should be your last resort for conveying information because it is hidden by default and often with zero or little visual indicator of its existence.

Before you add a tooltip, please consider: Is this information essential and necessary* Can the UI be made clearer? Can the information be shown on the page by default?

**Attention**: we use `aria-label` for tooltip contents, because it is crucial that they are accessible to screen reader users. However, `aria-label` **replaces** the text content of an element in screen readers, so only use `.tooltipped` on elements with no existing text content, or consider using `title` for supplement information.

**Note:** Tooltip classes will conflict with Octicon styles, and as such, must be applied to the parent element instead of the icon.

Expand Down