Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation updates #814

Merged
merged 9 commits into from
Jun 20, 2019
Merged

Documentation updates #814

merged 9 commits into from
Jun 20, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Jun 5, 2019

Lots of docs updates! 🎉

cc @primer/ds-core

@vercel
Copy link

vercel bot commented Jun 5, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@emplums emplums changed the title remove sync script documentation Documentation updates Jun 5, 2019
@emplums emplums requested a review from shawnbot June 5, 2019 22:49
@emplums
Copy link
Contributor Author

emplums commented Jun 5, 2019

@shawnbot all this module stuff is old and can be deleted, right? https://github.com/primer/css/pull/814/files#diff-64ddcb298d38150808f26fc28518e917L183

@emplums emplums requested a review from jonrohan June 6, 2019 16:11
jonrohan
jonrohan approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Had one question I think might be a typo.

pages/css/index.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging June 20, 2019 17:56 Inactive
@shawnbot shawnbot changed the base branch from master to release-12.4.1 June 20, 2019 17:56
@vercel vercel bot temporarily deployed to staging June 20, 2019 17:57 Inactive
@shawnbot shawnbot mentioned this pull request Jun 20, 2019
Merged
13 tasks
@shawnbot shawnbot merged commit 7d12193 into release-12.4.1 Jun 20, 2019
@shawnbot shawnbot deleted the update-docs branch June 20, 2019 18:08
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Open
This was referenced Dec 24, 2022
Open
Open
This was referenced Dec 27, 2022
Open
Open
This was referenced Jan 3, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@shawnbot shawnbot Awaiting requested review from shawnbot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emplums @jonrohan @shawnbot