Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color utility table tweaks #842

Merged
merged 6 commits into from
Jul 19, 2019
Merged

Color utility table tweaks #842

merged 6 commits into from
Jul 19, 2019

Conversation

shawnbot
Copy link
Contributor

This PR removes the "system" utility columns (.bg-red-0, .color-gray-9, etc.) from the color utility tables introduced in #811 and hides rows in the background and text utility tables that don't have an alias like .bg-gray-light or .text-green. /cc @broccolini

@shawnbot shawnbot requested a review from simurai July 18, 2019 23:36
@vercel
Copy link

vercel bot commented Jul 18, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

simurai
simurai approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that all the .bg-[color]-[n] utilities are removed again (from the docs), does this mean they are somewhat "private". Like they could be used, but it's not really encouraged?

Otherwise LGTM. 🚢👍

@simurai simurai mentioned this pull request Jul 19, 2019
Merged
16 tasks
@shawnbot
Copy link
Contributor Author

Now that all the .bg-[color]-[n] utilities are removed again (from the docs), does this mean they are somewhat "private". Like they could be used, but it's not really encouraged?

That's basically true, yeah. They exist, but we're not promoting them for now 😁

@shawnbot shawnbot merged commit ab2341e into release-12.5.0 Jul 19, 2019
@shawnbot shawnbot deleted the color-util-tweaks branch July 19, 2019 17:21
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 19, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @simurai