Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.6.1 #872

Merged
merged 21 commits into from
Aug 23, 2019
Merged

Release 12.6.1 #872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f48d63f
Make (left) icons optional
simurai Jul 22, 2019
57178b8
Add icons to all buttons
simurai Jul 22, 2019
64b5962
Updating the changelog for 12.6
jonrohan Aug 13, 2019
e4b6b38
Update Colorable url
kiendang Aug 16, 2019
d164fd7
:fire: Remove animation
simurai Aug 21, 2019
5a05ab5
Merge branch 'master' into select-menu-spacing
simurai Aug 22, 2019
7aa838b
Use flexbox for the items
simurai Aug 22, 2019
887b233
Update select-menu.md
simurai Aug 22, 2019
7608d2f
Remove non-ascii characters from scss files
shreve Aug 22, 2019
1b6a70d
npm version patch
shawnbot Aug 22, 2019
12568b4
Update package-lock.json
shawnbot Aug 22, 2019
35ea61d
Merge pull request #870 from shreve/master
shawnbot Aug 22, 2019
b8ac473
Merge pull request #866 from primer/12-6-changelog
shawnbot Aug 22, 2019
4fb1ab7
Merge pull request #868 from primer/sidenav-animation
shawnbot Aug 22, 2019
0577196
Use spacing variable
simurai Aug 23, 2019
ec86465
Add empty commit to re-run checks
simurai Aug 23, 2019
c6eb450
Merge pull request #844 from primer/select-menu-spacing
simurai Aug 23, 2019
7fd6d37
Merge branch 'master' into pr/867
simurai Aug 23, 2019
9576243
Merge pull request #867 from kiendang/patch-1
simurai Aug 23, 2019
511b449
Update CHANGELOG.md
simurai Aug 23, 2019
89f3997
Update 12.6.0 changelog
simurai Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make (left) icons optional
  • Loading branch information
@simurai
simurai committed Jul 22, 2019
commit f48d63f736f554e81740b6a67f6eef3cde628ea1
4 changes: 2 additions & 2 deletions pages/css/components/select-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ Add a `.SelectMenu-icon .octicon-check` icon and it will show up when `aria-chec
<svg class="SelectMenu-icon octicon octicon-check" style="fill:currentColor" viewBox="0 0 12 16" version="1.1" width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M12 5l-8 8-4-4 1.5-1.5L4 10l6.5-6.5L12 5z"></path></svg>
Selected state
</button>
<button class="SelectMenu-item" role="menuitemcheckbox">Default state</button>
<button class="SelectMenu-item" role="menuitemcheckbox">Default state</button>
<button class="SelectMenu-item pl-6" role="menuitemcheckbox">Default state</button>
<button class="SelectMenu-item pl-6" role="menuitemcheckbox">Default state</button>
</menu>
</div>
</div>
Expand Down
13 changes: 4 additions & 9 deletions src/select-menu/select-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@
padding: $spacer-3;

@include breakpoint(sm) {
padding: $spacer-2;
padding-top: $spacer-2;
padding-bottom: $spacer-2;
}
}

Expand Down Expand Up @@ -175,7 +176,7 @@
.SelectMenu-item {
display: block;
width: 100%;
padding: $spacer-3 $spacer-5;
padding: $spacer-3;
overflow: hidden;
color: $text-gray;
text-align: left;
Expand All @@ -199,9 +200,7 @@
// The icon shown on the left of a list item. Typically a check icon.

.SelectMenu-icon {
position: absolute;
height: 1.5em; // Mimics line-height to vertically center the icon
margin-left: -20px;
margin-right: $spacer-2;
visibility: hidden;
transition: transform 0.12s cubic-bezier(0.5, 0.1, 1, 0.5), visibility 0s 0.12s linear;
transform: scale(0);
Expand Down Expand Up @@ -296,10 +295,6 @@
&:last-child {
border-bottom: 0;
}

@include breakpoint(sm) {
padding: $spacer-1 $spacer-2;
}
}

// Footer
Expand Down