Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in flex-justify-start explanation #877

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fix mistake in flex-justify-start explanation #877

merged 1 commit into from
Sep 4, 2019

Conversation

dcastil
Copy link
Contributor

@dcastil dcastil commented Sep 1, 2019

When using

.container {
  display: flex;
  justify-content: flex-start;
  flex-direction: column;
}

the start line is at the top of the container, not the end line.

Source: https://developer.mozilla.org/en-US/docs/Web/CSS/justify-content

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Sep 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-fork-dcastil-patch-1.primer.now.sh

@dcastil
Copy link
Contributor Author

dcastil commented Sep 1, 2019

Please let me know if anything is missing in this PR. I‘m on a mobile phone on a slow internet connection at the moment and wasn‘t able to read any issues or READMEs.

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if anything is missing in this PR.

@dcastil All good, thanks for fixing the docs. 🙇 ❤️ It will go in our next release.

@simurai simurai changed the base branch from master to release-12.7.0 September 4, 2019 06:25
@simurai simurai mentioned this pull request Sep 4, 2019
11 tasks
@shawnbot shawnbot merged commit 8793beb into primer:release-12.7.0 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants