Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize and lint scripts; remove unused dev dependencies #890

Merged
merged 13 commits into from
Sep 10, 2019
Merged

Reorganize and lint scripts; remove unused dev dependencies #890

merged 13 commits into from
Sep 10, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 10, 2019 •
edited
Loading

It's time to clean house in the scripts directory and devDependencies! Here's the deal:

  • 💥 We no longer distribute a build/ directory:
    • build/build.css → dist/primer.css
    • build/build.json → dist/stats/primer.json
    • build/index.js → dist/primer.js (the main field in package.json was updated in 12.0.0, so require('@primer/css') will continue to work the same)
  • All JS scripts in script/ now have the .js extension so that eslint can find them.
  • The docs URL test has now been consolidated into a single file with the style guide paths inlined, since they'll never change at this point.
  • Over a dozen dev dependencies are gone! Many were unused; some were removed after I refactored the docs URL test.
  • lib/erb-to-html.js is gone, as we aren't using it anymore in Doctocat. /cc @colebemis

@shawnbot
remove build directory
afd5a05 
BREAKING CHANGE: the build directory is no longer included in the
distributed package. build/stats.json can be found at
dist/stats/primer.json, and `require('@primer/css/build')` references
should be rewritten to `require('@primer/css/dist/primer')`.
@shawnbot
remove now-* npm scripts
2b3ae9d
@shawnbot
disable no-console in script/
5a9ebe6
@shawnbot
remove styleguide path cache
398b6a3
@shawnbot
remove docs-test/exceptions.js
b2c942b
@shawnbot
docs-test/urls.js -> script/test-doc-urls.js
09bab3b
@shawnbot
nix lib/erb-to-html
a02dd77
@shawnbot
rename JS scripts to *.js; lint
3e91364
@shawnbot
update script paths in package.json
d830495
@shawnbot
remove lots of unused dev dependencies!
2135b52
@vercel
Copy link

vercel bot commented Sep 10, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-tidy-scripts-deps.primer.now.sh

@shawnbot shawnbot marked this pull request as ready for review September 10, 2019 18:42
This was referenced Sep 10, 2019
Merged
Merged
@shawnbot shawnbot changed the title Tidy scripts and dev dependencies Reorganize and lint scripts; remove unused dev dependencies Sep 10, 2019
colebemis
colebemis approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 Always happy to see more deletions than additions 😄

@shawnbot shawnbot removed the request for review from jonrohan September 10, 2019 20:05
@shawnbot shawnbot merged commit 06ead4c into release-13.0.0 Sep 10, 2019
@shawnbot shawnbot deleted the tidy-scripts-deps branch September 10, 2019 20:05
This was referenced Dec 18, 2022
Open
Open
This was referenced Jan 1, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
Tag: Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @colebemis