Skip to content

Commit

Permalink
Revert "Adjust focus styling of textarea and input" (#3998)
Browse files Browse the repository at this point in the history
* Revert "Adjust focus styling of `textarea` and `input` (#3965)"

This reverts commit c4216ef.

* chore: add changeset

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
  • Loading branch information
joshblack and joshblack authored Dec 1, 2023
1 parent 27d2c15 commit dd285e2
Show file tree
Hide file tree
Showing 6 changed files with 137 additions and 199 deletions.
5 changes: 5 additions & 0 deletions .changeset/chilly-spies-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Remove changes to focus outline to prevent double focus rings from showing
35 changes: 14 additions & 21 deletions src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ exports[`snapshots renders a custom empty state message 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -51,8 +50,8 @@ exports[`snapshots renders a custom empty state message 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -188,7 +187,6 @@ exports[`snapshots renders a loading state 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -218,8 +216,8 @@ exports[`snapshots renders a loading state 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -390,7 +388,6 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -420,8 +417,8 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -1168,7 +1165,6 @@ exports[`snapshots renders a multiselect input 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -1198,8 +1194,8 @@ exports[`snapshots renders a multiselect input 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -1833,7 +1829,6 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -1863,8 +1858,8 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -2646,7 +2641,6 @@ exports[`snapshots renders a single select input 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -2676,8 +2670,8 @@ exports[`snapshots renders a single select input 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down Expand Up @@ -3670,7 +3664,6 @@ exports[`snapshots renders with an input value 1`] = `
-ms-flex-align: stretch;
align-items: stretch;
min-height: 32px;
overflow: hidden;
}
.c0 input,
Expand Down Expand Up @@ -3700,8 +3693,8 @@ exports[`snapshots renders with an input value 1`] = `
.c0:focus-within {
border-color: #0969da;
outline: 2px solid #0969da;
outline-offset: -1px;
outline: none;
box-shadow: inset 0 0 0 1px #0969da;
}
.c0 > textarea {
Expand Down
Loading

0 comments on commit dd285e2

Please sign in to comment.