-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic SegmentedControl functionality #2108
Merged
Merged
Changes from 4 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
515a087
implements basic SegmentedControl functionality
mperrotti e0605c5
updates file structure
mperrotti d2c6d5a
adds SegmentedControl to drafts
mperrotti 5f8bd3c
adds changeset
mperrotti 52eee4e
fixes TypeScripts issues
mperrotti d10dd54
revert package-lock.json changes
mperrotti 093e6a2
fixes SegmentedControl tests and updates snapshot
mperrotti 2ae5107
style bug fixes
mperrotti 54ca574
Update src/SegmentedControl/fixtures.stories.tsx
mperrotti 054c2f0
improve visual design for hover and active states
mperrotti d0a00d4
Merge branch 'main' of github.com:primer/react into mp/segmented-cont…
mperrotti 4958387
ARIA updates from Chelsea's feedback
mperrotti 1f20ce9
Merge branch 'mp/segmented-control-basic' of github.com:primer/react …
mperrotti 813e1bb
updates tests and snapshots
mperrotti afdeba8
Ignore *.test.tsx files in build types
colebemis 563547b
Use named export for SegmentedControl
colebemis 8dbf6aa
Update package-lock.json
colebemis c952c59
Merge branch 'mp/segmented-control-basic' of github.com:primer/react …
mperrotti b1253ec
Merge branch 'main' of github.com:primer/react into mp/segmented-cont…
mperrotti e14b6c0
updates lock file
mperrotti 5278c3b
fixes checkExports test for SegmentedControl
mperrotti 4ab92d0
design tweak for icon-only segmented control button
mperrotti 8bb8ba3
Merge branch 'main' of github.com:primer/react into mp/segmented-cont…
mperrotti 4695c84
Merge branch 'main' into mp/segmented-control-basic
colebemis 8f22b04
Merge branch 'main' into mp/segmented-control-basic
mperrotti c03b4e1
Merge branch 'main' into mp/segmented-control-basic
mperrotti 7ea6424
Merge branch 'main' into mp/segmented-control-basic
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export {default} from './SegmentedControl' | ||
export * from './SegmentedControl' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is there a reason you're setting
aria-label
on the SVG and the button? I think by default the SVGs rendered by octicons are aria-hiddenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just used it so I could select it with React test utils.
I wouldn't do this in a real UI.