chore(deps-dev): bump @types/react from 18.0.28 to 18.2.21

[dependabot]

Bumps @types/react from 18.0.28 to 18.2.21.

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 313394d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[joshblack]

Would love to get your take on the changes @broccolinisoup 👀 Wasn't sure of the best way to resolve the TypeScript errors so am curious what approach you would take here.

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.59 KB (0%)
dist/browser.umd.js	105.14 KB (0%)

[broccolinisoup]

Thanks @joshblack for the ping!

I looked at the type errors without checking out your commits to see how I would have solved them 😄

Regarding

• the Dialog content type issue, the way you solved was my instinct as well!
• the dangerousRenderedHTML.__html issue, it is an interesting one. toString() makes a lot of sense to me. I might have opted in using as string mainly because I am having a hard time to understand what TrustedHTML type html looks like and how it is different than string type html. Curious to hear if you have thoughts or examples to share!

[broccolinisoup]

Left a comment to share my thoughts but this looks great to me 🚀

[joshblack]

@broccolinisoup same, I wasn't quite about TrustedHTML either. I went for toString() from: https://developer.mozilla.org/en-US/docs/Web/API/TrustedHTML since it seemed like that would provide a string containing sanitized HTML but in the examples they also just set innerHTML to the value itself so 🤷‍♂️

I'm going to use your suggestion as string since it seems like the direct assignment could have specific behavior:

The sanitized value can then be used with Element.innerHTML to ensure that no new HTML elements can be injected.