Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dialog button spacing #3918

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix Dialog button spacing #3918

merged 3 commits into from
Nov 9, 2023

Conversation

dylanatsmith
Copy link
Contributor

Changelog

Changed

Changes dialog footer button spacing from 4px to 8px as is standard

Before

image

After
image

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

8px instead of 4px
Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 7f88600

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanatsmith dylanatsmith self-assigned this Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Uh oh! @dylanatsmith, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

src/Dialog/Dialog.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 8, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104 KB (-0.02% 🔽)
dist/browser.umd.js 104.54 KB (-0.02% 🔽)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this ✨

@dylanatsmith dylanatsmith marked this pull request as ready for review November 8, 2023 16:33
@dylanatsmith dylanatsmith requested review from a team and mperrotti November 8, 2023 16:33
@joshblack joshblack added this pull request to the merge queue Nov 8, 2023
@joshblack joshblack removed this pull request from the merge queue due to a manual request Nov 8, 2023
@dylanatsmith dylanatsmith added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit e8d0c15 Nov 9, 2023
29 checks passed
@dylanatsmith dylanatsmith deleted the dylanatsmith-patch-1 branch November 9, 2023 16:03
@primer primer bot mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants