Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining Axe errors in Storybook #4704

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

TylerJDev
Copy link
Contributor

Changelog

Changed

Fixes some Axe errors present in some stories in Storybook.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Only affects Storybook and does not require a version bump.

Merge checklist

@TylerJDev TylerJDev requested a review from a team as a code owner June 28, 2024 13:38
@TylerJDev TylerJDev requested a review from camertron June 28, 2024 13:38
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: baca515

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 28, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.97 KB (0%)
packages/react/dist/browser.umd.js 91.25 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4704 June 28, 2024 13:43 Inactive
@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Jun 28, 2024
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just had that one img error pop up

@TylerJDev TylerJDev added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 93f2ac0 Jun 28, 2024
30 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/fix-axe-errors branch June 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants