-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(SelectPanel): update tests to account for more of API #4705
Conversation
|
size-limit report 📦
|
bump @siddharthkp when you get a sec 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding these tests 🙏🏻
Question: I assume these are the current behaviours since all tests pass. Is there any behaviour that we know for sure that it will change after we implement the accessibility remediations? If there are some, we might want to add comments on them to help us refactor the tests later.
Let me know if I am not making sense!
@broccolinisoup my understanding since we're keeping the combobox-related functionality is that it should mostly be the same behavior, if I remember right 👀 |
Oh this is great! Thanks for sharing that. |
As we're working more on the v1 of SelectPanel, I wanted to add some additional tests to the test suite.
This is not complete coverage but figured I'd add what I could this week and revisit another time for what was missed
Changelog
New
Changed
Removed
Rollout strategy
This is a change that adds tests to Select Panel