Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(SelectPanel): update tests to account for more of API #4705

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

joshblack
Copy link
Member

As we're working more on the v1 of SelectPanel, I wanted to add some additional tests to the test suite.

This is not complete coverage but figured I'd add what I could this week and revisit another time for what was missed

Changelog

New

Changed

  • Update tests for Select Panel

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change that adds tests to Select Panel

@joshblack joshblack requested a review from a team as a code owner June 28, 2024 16:50
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 79e8cc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 28, 2024
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.97 KB (0%)
packages/react/dist/browser.umd.js 91.25 KB (0%)

@joshblack
Copy link
Member Author

bump @siddharthkp when you get a sec 👀

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding these tests 🙏🏻

Question: I assume these are the current behaviours since all tests pass. Is there any behaviour that we know for sure that it will change after we implement the accessibility remediations? If there are some, we might want to add comments on them to help us refactor the tests later.

Let me know if I am not making sense!

@joshblack
Copy link
Member Author

@broccolinisoup my understanding since we're keeping the combobox-related functionality is that it should mostly be the same behavior, if I remember right 👀

@joshblack joshblack added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 9ad19a5 Jul 16, 2024
35 of 36 checks passed
@joshblack joshblack deleted the refactor/update-select-panel-tests branch July 16, 2024 16:23
@broccolinisoup
Copy link
Member

@broccolinisoup my understanding since we're keeping the combobox-related functionality is that it should mostly be the same behavior, if I remember right 👀

Oh this is great! Thanks for sharing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants