Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing displayName to PageHeader.TitleArea and PageHeader.ParentLink #4736

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Jul 12, 2024

Changelog

Changed

Added displayName to PageHeader.TitleArea and PageHeader.ParentLink sub components.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@lumaxis lumaxis requested a review from a team as a code owner July 12, 2024 10:39
@lumaxis lumaxis requested a review from keithamus July 12, 2024 10:39
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: bbc7c9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 12, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.21 KB (0%)
packages/react/dist/browser.umd.js 91.54 KB (0%)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for pushing this PR 🙏🏻 Left two questions 👀 Approving in advance!

@@ -337,6 +337,7 @@ const TitleArea = React.forwardRef<HTMLDivElement, React.PropsWithChildren<Title
)
},
) as PolymorphicForwardRefComponent<'div', TitleAreaProps>
TitleArea.displayName = 'TitleArea'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for adding this! We initially had all sub components FC so I think React was able to infer their names but then we refactored a couple if them.

Do you mind adding the same thing to Parent Link? 🙏🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, updated! Do you think we need it for Root, too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a displayName for Root

export const PageHeader = Object.assign(Root, {
  ContextArea,
  ParentLink,
  ContextBar,
  TitleArea,
  ContextAreaActions,
  LeadingAction,
  Breadcrumbs,
  LeadingVisual,
  Title,
  TrailingVisual,
  TrailingAction,
  Actions,
  Description,
  Navigation,
})

PageHeader.displayName = 'PageHeader'

.changeset/funny-dots-yawn.md Outdated Show resolved Hide resolved
@lumaxis lumaxis force-pushed the titlearea-missing-displayname branch from 2b2e30e to 3704183 Compare July 15, 2024 09:39
@lumaxis lumaxis changed the title Add missing displayName to PageHeader.TitleArea Add missing displayName to PageHeader.TitleArea and PageHeader.ParentLink Jul 15, 2024
@lumaxis lumaxis added the skip changeset This change does not need a changelog label Jul 15, 2024
@broccolinisoup broccolinisoup added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit c7c0c47 Jul 19, 2024
33 checks passed
@broccolinisoup broccolinisoup deleted the titlearea-missing-displayname branch July 19, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants