Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More a11y fixes for Storybook stories #4959

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Sep 13, 2024

Closes https://github.com/github/primer/issues/3429, https://github.com/github/primer/issues/3479

Pairs with primer/design#859

Adds more context to some storybook stories.

Changelog

New

Changed

  • Add icons to Flash examples, to not solely rely on color to convey meaning
  • Add Heading to PageHead examples, to demonstrate real-world usage with a heading

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: e48f0b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.16 KB (0%)
packages/react/dist/browser.umd.js 97.4 KB (0%)

@TylerJDev TylerJDev added skip changeset This change does not need a changelog update snapshots labels Sep 13, 2024
@TylerJDev TylerJDev added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 8ee4264 Sep 13, 2024
32 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/more-storybook-a11y-fixes branch September 13, 2024 17:27
Copy link
Contributor

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants