Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primer/variables rule #28

Merged
merged 33 commits into from
Oct 2, 2019
Merged

Add primer/variables rule #28

merged 33 commits into from
Oct 2, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Apr 10, 2019 •
edited
Loading

This introduces a primer/variables rule that:

  1. Warns whenever a static value is used for any of the configured properties.
  2. Can replace (via --fix) static values with their exact variable value matches.

📝 Check out the docs and the tests for more info.

@shawnbot shawnbot changed the base branch from release-6.0.0 to master April 11, 2019 21:06
@shawnbot shawnbot marked this pull request as ready for review July 15, 2019 22:29
shawnbot
shawnbot commented Jul 15, 2019
View reviewed changes
__tests__/variables.js Outdated Show resolved Hide resolved
shawnbot
shawnbot commented Jul 15, 2019
View reviewed changes
__tests__/variables.js Outdated Show resolved Hide resolved
@shawnbot shawnbot mentioned this pull request Oct 2, 2019
Merged
4 tasks
@shawnbot shawnbot changed the base branch from master to release-8.2.0 October 2, 2019 21:58
@shawnbot shawnbot merged commit b0fbb63 into release-8.2.0 Oct 2, 2019
@shawnbot shawnbot deleted the plugin-variables branch October 2, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shawnbot