Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins that are not useful anymore #401

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 18, 2024

This PR removes some of the plugins that we used for migration in the past.

  • primer/new-color-vars-have-fallback
  • primer/no-deprecated-colors
  • primer/no-override
  • primer/no-scale-colors
  • primer/no-undefined-vars
  • primer/no-unused-vars

For primer/no-undefined-vars we decided to replace with a community plugin https://github.com/csstools/stylelint-value-no-unknown-custom-properties which does the same for us but is better maintained.

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: b14b767

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/stylelint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the title Remove unused plugins Remove plugins that are not useful anymore Apr 18, 2024
@jonrohan jonrohan marked this pull request as ready for review April 18, 2024 21:22
@jonrohan jonrohan requested a review from a team as a code owner April 18, 2024 21:22
Copy link
Collaborator

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jonrohan jonrohan merged commit 0a7bc7e into main Apr 18, 2024
2 checks passed
@jonrohan jonrohan deleted the remove_unused_plugins branch April 18, 2024 21:51
@primer-css primer-css mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants