Upgrade to the latest versions of rubocop-rails-accessibility and erb…

…lint-github (#3100)

Co-authored-by: camertron <camertron@users.noreply.github.com>

.erb-lint.yml

@@ -27,7 +27,7 @@ linters:
         Enabled: false
         Exclude:
           - app/components/primer/layout_component.html.erb
-      Primer/Migrations/IconButtonComponent:
+      Migrations/IconButtonComponent:
         Enabled: true
-      Primer/Migrations/TruncateComponent:
+      Migrations/TruncateComponent:
         Enabled: true

.github/workflows/lint.yml

@@ -47,14 +47,11 @@ jobs:
           demo/**/*.rb
           test/**/*.rb
     - uses: ruby/setup-ruby@v1
-      if: steps.changed-files.outputs.any_changed == 'true'
       with:
         ruby-version: '3.3'
         bundler-cache: true
     - name: Lint with Rubocop
-      if: steps.changed-files.outputs.any_changed == 'true'
-      run: |
-        bundle exec rubocop ${{ steps.changed-files.outputs.all_changed_files }} --format github
+      run: script/rubocop --format github
 
   erblint:
     runs-on: ubuntu-latest
@@ -67,14 +64,11 @@ jobs:
         files: |
           app/components/**/*.erb
     - uses: ruby/setup-ruby@v1
-      if: steps.changed-files.outputs.any_changed == 'true'
       with:
         ruby-version: '3.3'
         bundler-cache: true
     - name: Lint with ERB Lint
-      if: steps.changed-files.outputs.any_changed == 'true'
-      run: |
-        bundle exec erblint ${{ steps.changed-files.outputs.all_changed_files }} --format github
+      run: script/erblint --format github
 
   eslint:
     runs-on: ubuntu-latest

Gemfile

@@ -53,8 +53,8 @@ group :development do
   gem "capybara", "~> 3.40.0"
   gem "cuprite", "~> 0.15"
   gem "debug"
-  gem "erb_lint", "~> 0.5.0"
-  gem "erblint-github", "~> 0.5.1"
+  gem "erb_lint", "~> 0.6"
+  gem "erblint-github", "~> 1.0"
   gem "listen", "~> 3.9"
   gem "matrix", "~> 0.4.2"
   gem "mocha"
@@ -63,7 +63,7 @@ group :development do
   gem "rubocop-github", "~> 0.20.0"
   gem "rubocop-performance"
   gem "rubocop-rails"
-  gem "rubocop-rails-accessibility", "~> 0.2.0"
+  gem "rubocop-rails-accessibility", "~> 1.0"
   gem "selenium-webdriver", "~> 4.18"
   gem "simplecov", "~> 0.22.0"
   gem "simplecov-console", "~> 0.9.1"

Gemfile.lock

@@ -85,14 +85,14 @@ GEM
     docile (1.4.0)
     drb (2.2.1)
     dry-cli (1.1.0)
-    erb_lint (0.5.0)
+    erb_lint (0.6.0)
       activesupport
       better_html (>= 2.0.1)
       parser (>= 2.7.1.4)
       rainbow
-      rubocop
+      rubocop (>= 1)
       smart_properties
-    erblint-github (0.5.1)
+    erblint-github (1.0.1)
     erubi (1.13.0)
     ferrum (0.14)
       addressable (~> 2.5)
@@ -103,7 +103,7 @@ GEM
     hashdiff (1.1.0)
     htmlbeautifier (1.4.3)
     htmlentities (4.3.4)
-    i18n (1.14.5)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     io-console (0.7.2)
     irb (1.14.0)
@@ -148,8 +148,8 @@ GEM
     nokogiri (1.16.7-x86_64-linux)
       racc (~> 1.4)
     octicons (19.9.0)
-    parallel (1.24.0)
-    parser (3.3.2.0)
+    parallel (1.26.3)
+    parser (3.3.5.0)
       ast (~> 2.4.1)
       racc
     pry (0.14.2)
@@ -199,21 +199,19 @@ GEM
     regexp_parser (2.9.2)
     reline (0.5.10)
       io-console (~> 0.5)
-    rexml (3.2.8)
-      strscan (>= 3.0.9)
+    rexml (3.3.7)
     rouge (4.2.1)
-    rubocop (1.64.1)
+    rubocop (1.66.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
+    rubocop-ast (1.32.3)
       parser (>= 3.3.1.0)
     rubocop-github (0.20.0)
       rubocop (>= 1.37)
@@ -227,7 +225,7 @@ GEM
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rails-accessibility (0.2.0)
+    rubocop-rails-accessibility (1.0.1)
       rubocop (>= 1.0.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
@@ -257,14 +255,13 @@ GEM
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
     stringio (3.1.1)
-    strscan (3.1.0)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.3.2)
     timecop (0.9.9)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (2.6.0)
     view_component (3.12.1)
       activesupport (>= 5.2.0, < 8.0)
       concurrent-ruby (~> 1.0)
@@ -305,8 +302,8 @@ DEPENDENCIES
   cssbundling-rails (~> 1.4)
   cuprite (~> 0.15)
   debug
-  erb_lint (~> 0.5.0)
-  erblint-github (~> 0.5.1)
+  erb_lint (~> 0.6)
+  erblint-github (~> 1.0)
   kramdown (~> 2.4)
   listen (~> 3.9)
   lookbook (~> 2.3.1)
@@ -322,7 +319,7 @@ DEPENDENCIES
   rubocop-github (~> 0.20.0)
   rubocop-performance
   rubocop-rails
-  rubocop-rails-accessibility (~> 0.2.0)
+  rubocop-rails-accessibility (~> 1.0)
   selenium-webdriver (~> 4.18)
   simplecov (~> 0.22.0)
   simplecov-console (~> 0.9.1)

lib/primer/forms/select.html.erb

@@ -3,4 +3,3 @@
     <%= builder.select(@input.name, options, @input.select_arguments, **@input.input_arguments) %>
   <% end %>
 <% end %>
-

previews/primer/alpha/action_bar_preview/inline.html.erb

@@ -1,6 +1,6 @@
 
 <%= render(Primer::BaseComponent.new(tag: :div, flex_items: :center, display: :flex)) do %>
-  <%= render(Primer::Beta::Heading.new(tag: :h1, font_size: 3, mr: 2)) { "Title" }%>
+  <%= render(Primer::Beta::Heading.new(tag: :h1, font_size: 3, mr: 2)) { "Title" } %>
   <%= render(Primer::Alpha::ActionBar.new) do |component| %>
     <% component.with_item_icon_button(icon: :search, label: "Search") %>
     <% component.with_item_icon_button(icon: :pencil, label: "Edit") %>

previews/primer/alpha/dialog_preview/autofocus_element.html.erb

@@ -2,7 +2,7 @@
   <% d.with_show_button { "Show Dialog" } %>
   <% d.with_body do %>
     <form>
-      <input type="text" placeholder="This element is focused on open" autofocus>
+      <input type="text" placeholder="This element is focused on open" autofocus autocomplete="off">
     </form>
   <% end %>
 <% end %>

previews/primer/alpha/dialog_preview/custom_header.html.erb

@@ -1,6 +1,8 @@
 <%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: title, subtitle: subtitle, visually_hide_title: false)) do |d| %>
   <% d.with_header(show_divider: show_divider) do %>
-    <button class="btn">Custom Header Controls</button>
+    <%= render(Primer::Beta::Button.new) do %>
+      Custom Header Controls
+    <% end %>
   <% end %>
   <% d.with_show_button { button_text } %>
   <% d.with_body { "Hello World" } %>

previews/primer/alpha/dialog_preview/dialog_inside_overlay.html.erb

@@ -5,16 +5,16 @@
       <% d.with_show_button { button_text } %>
       <% d.with_body { body_text } %>
       <% d.with_footer(show_divider: true) do %>
-        <%= render(Primer::ButtonComponent.new(data: { "close-dialog-id": "dialog-one" })) { "Cancel" } %>
+        <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "dialog-one" })) { "Cancel" } %>
       <% end %>
     <% end %>
   <% end %>
 <% end %>
 
-<script type="module">
-document.getElementById('overlay-show-first-overlay')?.addEventListener('click', e => {
+<script>
+  document.getElementById('overlay-show-first-overlay')?.addEventListener('click', e => {
     setTimeout(() => {
-        document.getElementById('first-overlay').querySelector('button')?.click()
+      document.getElementById('first-overlay').querySelector('button')?.click()
     });
   });
 </script>

previews/primer/alpha/dialog_preview/nested_dialog.html.erb

@@ -14,7 +14,7 @@
 <% end %>
 
 <div style="margin-top:2rem">
-<%= render(Primer::Beta::Flash.new(scheme: :warning)) do %>
+<%= render(Primer::Alpha::Banner.new(scheme: :warning)) do %>
   <p>Please be careful nesting dialogs! Note that in this example, opening the second dialog does not close the first.</p>
   <p>Closing a dialog while opening a dialog inside, will cause both to be invisible which will lead to undesired effects!</p>
 <% end %>

previews/primer/alpha/dialog_preview/with_footer.html.erb

@@ -2,7 +2,7 @@
   <% d.with_show_button { button_text } %>
   <% d.with_body { "Content" } %>
   <% d.with_footer(show_divider: show_divider) do %>
-    <%= render(Primer::ButtonComponent.new(data: { "close-dialog-id": "my-dialog" })) { "Cancel" } %>
-    <%= render(Primer::ButtonComponent.new(scheme: :primary)) { "Submit" } %>
+    <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "my-dialog" })) { "Cancel" } %>
+    <%= render(Primer::Beta::Button.new(scheme: :primary)) { "Submit" } %>
   <% end %>
 <% end %>

previews/primer/alpha/dialog_preview/with_form.html.erb

@@ -5,8 +5,8 @@
       This is a custom dialog with the body and footer wrapped in a form tag.
     <% end %>
     <%= render(Primer::Alpha::Dialog::Footer.new(show_divider: show_divider)) do %>
-      <%= render(Primer::ButtonComponent.new(data: { "close-dialog-id": "my-dialog" })) { "Cancel" } %>
-      <%= render(Primer::ButtonComponent.new(scheme: :primary)) { "Submit" } %>
+      <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "my-dialog" })) { "Cancel" } %>
+      <%= render(Primer::Beta::Button.new(scheme: :primary)) { "Submit" } %>
     <% end %>
   </form>
 <% end %>

previews/primer/alpha/dialog_preview/with_text_input.html.erb

@@ -5,7 +5,7 @@
 
     <form>
       <label for="dialog-text-input-example">Example input</label>
-      <input id="dialog-text-input-example" type="text" value="Some text goes in here">
+      <input id="dialog-text-input-example" type="text" value="Some text goes in here" autocomplete="off">
     </form>
   <% end %>
 <% end %>

previews/primer/alpha/overlay_preview/in_a_sticky_container.html.erb

@@ -16,4 +16,4 @@
     <% d.with_body { "This is a long body for the overlay dialog. <br>".html_safe * 20 } %>
   <% end %>
 </div>
-<div style="height:3000px;"></div>
+<div style="height:3000px;"></div>

previews/primer/alpha/overlay_preview/overlay_with_header_filter.html.erb

@@ -13,4 +13,4 @@
   <% d.with_show_button { "Show Overlay" } %>
   <% d.with_footer { "Large Dialog Footer" } %>
   <% d.with_body { "This is a long body for the overlay dialog. <br>".html_safe * 20 } %>
-<% end %>
+<% end %>

previews/primer/alpha/select_panel_preview/_interaction_subject_js.html.erb

@@ -1,4 +1,4 @@
-<script type="application/javascript">
+<script>
   function ready(fn) {
     if (document.readyState !== 'loading') {
       fn()

previews/primer/alpha/text_field_preview/input_group_leading_action_menu.html.erb

@@ -1,5 +1,4 @@
- 
-<%= render(Primer::BaseComponent.new(tag: :div, flex_items: :center, display: :flex)) do %>
+ <%= render(Primer::BaseComponent.new(tag: :div, flex_items: :center, display: :flex)) do %>
   <%= form_with(url: action_menu_form_action_path(format: route_format)) do |f| %>
     <%= render(Primer::Alpha::ActionMenu.new(select_variant: :single, form_arguments: { builder: f, name: "foo" })) do |menu| %>
       <% menu.with_show_button(classes: "rounded-right-0 border-right-0") { |button| button.with_trailing_action_icon(icon: :"triangle-down"); "Filter" } %>

previews/primer/alpha/tooltip_preview/tooltip_inside_primer_overlay.html.erb

@@ -6,10 +6,10 @@
     Open Overlay
     <% b.with_tooltip(text: "Opens an overlay") %>
   <% end %>
-  <% d.with_header do  %>
+  <% d.with_header do %>
     An overlay
   <% end %>
-  <% d.with_body do  %>
+  <% d.with_body do %>
 
     <%= render(Primer::Beta::Button.new(id: "overlay-button")) do |b| %>
       <% b.with_tooltip(text: "This is a tooltip in an Overlay") %>

previews/primer/alpha/tooltip_preview/tooltip_with_dialog_moving_focus_to_input.html.erb

@@ -13,7 +13,7 @@
 <% end %>
 <label>
   An input
-  <input type="text" id="input">
+  <input type="text" id="input" autocomplete="off">
 </label>
 <script>
   document.querySelector('#my-dialog').addEventListener('close', function () {

previews/primer/alpha/underline_nav_preview/default.html.erb

@@ -3,6 +3,6 @@
     <% component.with_tab(href: "#", selected: i.zero?) { "Item #{i + 1}" } %>
   <% end %>
   <% component.with_actions do %>
-    <%= render(Primer::ButtonComponent.new) { "Button" } %>
+    <%= render(Primer::Beta::Button.new) { "Button" } %>
   <% end %>
 <% end %>

previews/primer/alpha/underline_nav_preview/playground.html.erb

@@ -3,6 +3,6 @@
     <% component.with_tab(href: "#", selected: i.zero?) { "Item #{i + 1}" } %>
   <% end %>
   <% component.with_actions do %>
-    <%= render(Primer::ButtonComponent.new) { "Button" } %>
+    <%= render(Primer::Beta::Button.new) { "Button" } %>
   <% end %>
 <% end %>

previews/primer/beta/auto_complete_preview/with_submit_button.html.erb

@@ -1,20 +1,20 @@
 <div class="d-flex flex-items-start flex-column flex-sm-row flex-sm-items-end" style="gap: .5rem">
-    <%= render(
-        Primer::Beta::AutoComplete.new(
-            label_text: label_text,
-            input_id: input_id,
-            list_id: list_id,
-            src: autocomplete_index_path,
-            show_clear_button: show_clear_button,
-            visually_hide_label: visually_hide_label,
-            placeholder: placeholder,
-            size: size,
-            full_width: full_width,
-            disabled: disabled,
-            invalid: invalid,
-            input_name: input_name
-    )) do |component| %>
-        <% component.with_leading_visual_icon(icon: :search) %>
-    <% end %>
-    <%= render(Primer::ButtonComponent.new(scheme: :primary)) { "Submit" } %>
+  <%= render(
+    Primer::Beta::AutoComplete.new(
+      label_text: label_text,
+      input_id: input_id,
+      list_id: list_id,
+      src: autocomplete_index_path,
+      show_clear_button: show_clear_button,
+      visually_hide_label: visually_hide_label,
+      placeholder: placeholder,
+      size: size,
+      full_width: full_width,
+      disabled: disabled,
+      invalid: invalid,
+      input_name: input_name
+  )) do |component| %>
+    <% component.with_leading_visual_icon(icon: :search) %>
+  <% end %>
+  <%= render(Primer::Beta::Button.new(scheme: :primary)) { "Submit" } %>
 </div>

previews/primer/beta/breadcrumbs_preview/with_deprecated_truncate.html.erb

@@ -8,7 +8,9 @@
 <%= render(Primer::Beta::Breadcrumbs.new) do |breadcrumbs| %>
   <% texts.each_with_index do |text, i| %>
     <% breadcrumbs.with_item(href: "##{i}") do %>
-      <%= render(Primer::Truncate.new(inline: true, max_width: 135)) { text } %>
+      <%=
+        render(Primer::Truncate.new(inline: true, max_width: 135)) { text } # rubocop:disable Migrations/TruncateComponent
+      %>
     <% end %>
   <% end %>
 <% end %>

previews/primer/beta/button_preview/summary_as_button.html.erb

@@ -11,4 +11,3 @@
   <% end %>
   <p>A wrapping `details` tag is required when using the button with the `:summary` tag</p>
 </details>
-

previews/primer/beta/subhead_preview/actions.html.erb

@@ -11,4 +11,3 @@
     <% end %>
   <% end %>
 <% end %>
-

script/erblint

@@ -3,6 +3,7 @@
 bundle exec erblint \
     app/**/*.html.erb \
     lib/**/*.html.erb \
-    demo/app/**/*.html.erb \
+    previews/**/*.html.erb \
     test/**/*.html.erb \
+    demo/app/**/*.html.erb \
     ${@}