-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce demo cleanup action #3025
Conversation
|
962b819
to
835f6b9
Compare
835f6b9
to
cf3c079
Compare
cf3c079
to
88c6dea
Compare
88c6dea
to
114c935
Compare
114c935
to
78286e3
Compare
78286e3
to
90e31c2
Compare
90e31c2
to
2a4cbca
Compare
2a4cbca
to
1f426fc
Compare
1f426fc
to
9067d1b
Compare
9067d1b
to
4f2ff28
Compare
4f2ff28
to
72c4cec
Compare
72c4cec
to
e298262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! deferring final approval to @jonrohan
There's another workflow that's |
@jonrohan I think it makes sense to keep both workflows. From what I've been able to tell, the demo-preview-destroy workflow is working as expected - we would have had a lot more old preview environments lying around if it had been failing. Almost all the ones I saw in the Azure console were quite old, probably created before we wrote that destroy Action. This cleanup Action is really just a safeguard in case the destroy Action fails occasionally. |
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR introduces an Actions workflow that cleans up old preview environments. We delete preview envs automatically when PRs are closed or merged, but we still had a number of old ones hanging around, ostensibly from before we implemented the auto-delete Action. These old preview envs were getting flagged by our automated security tooling. I tried to delete them manually via the Azure console but didn't have permission (what a surprise), so I decided to put in the effort to create this cleanup Action. It runs at 12 noon every day (5am PT).
Integration
No changes necessary in production.
Risk Assessment
Accessibility