Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No_std Support #13

Merged
merged 17 commits into from
Mar 5, 2024
Merged

No_std Support #13

merged 17 commits into from
Mar 5, 2024

Conversation

SimonIT
Copy link
Contributor

@SimonIT SimonIT commented Feb 9, 2023

Closes #12

@SimonIT SimonIT marked this pull request as draft February 9, 2023 15:15
@SimonIT
Copy link
Contributor Author

SimonIT commented Feb 9, 2023 •
edited
Loading

I think we have to wait on rust-lang/rust#103765 to have error in core with the stable rust version.
There's also currently the problem, that Error in core doesn't implement Sized which is needed for example for Result or From

yaahc
yaahc reviewed Feb 10, 2023
View reviewed changes
src/result.rs Outdated Show resolved Hide resolved
NicolasDP
NicolasDP reviewed Feb 25, 2023
View reviewed changes
src/se.rs Outdated Show resolved Hide resolved
@SimonIT SimonIT marked this pull request as ready for review March 3, 2023 09:44
This was referenced Mar 8, 2023
Closed
Draft
@SimonIT
Copy link
Contributor Author

SimonIT commented Mar 5, 2024

@NicolasDP Any opinions?

@NicolasDP
Copy link
Contributor

Looking good, thanks for pointing this back to me.

@NicolasDP NicolasDP merged commit 2b6330a into primetype:master Mar 5, 2024
@NicolasDP NicolasDP mentioned this pull request Mar 5, 2024
Closed
@SimonIT SimonIT deleted the no_std branch March 5, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaahc yaahc yaahc left review comments

@NicolasDP NicolasDP NicolasDP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discussion] no_std support
4 participants
@SimonIT @NicolasDP @yaahc @connectety