test: add TiDB into the engine tests

.github/workflows/query-engine.yml

@@ -51,8 +51,12 @@ jobs:
             single_threaded: false
             connector: "cockroachdb"
             version: "22.1"
+          - name: "tidb"
+            single_threaded: false
+            connector: "tidb"
         engine_protocol: [graphql, json]
 
+
     env:
       LOG_LEVEL: "info"
       LOG_QUERIES: "y"

.github/workflows/schema-engine.yml

@@ -70,6 +70,9 @@ jobs:
             url: "mysql://root:prisma@localhost:3307"
           - name: mysql_mariadb
             url: "mysql://root:prisma@localhost:3308"
+          - name: tidb
+            url: "mysql://root@localhost:4000"
+            single_threaded: true
           - name: postgres9
             url: "postgresql://postgres:prisma@localhost:5431"
           - name: postgres10

.test_database_urls/tidb

@@ -0,0 +1,2 @@
+export TEST_DATABASE_URL="mysql://root@localhost:4000"
+unset TEST_SHADOW_DATABASE_URL

Makefile

@@ -164,6 +164,12 @@ start-mysql_mariadb:
 dev-mariadb: start-mysql_mariadb
 	cp $(CONFIG_PATH)/mariadb $(CONFIG_FILE)
 
+start-tidb:
+	docker compose -f docker-compose.yml up -d --remove-orphans tidb
+
+dev-tidb: start-tidb
+	cp $(CONFIG_PATH)/tidb $(CONFIG_FILE)
+
 start-mssql_2019:
 	docker compose -f docker-compose.yml up -d --remove-orphans mssql-2019
 

docker-compose.yml

@@ -180,6 +180,16 @@ services:
       - databases
     tmpfs: /var/lib/mariadb
 
+  tidb:
+    image: pingcap/tidb:v7.1.0
+    restart: always
+    platform: linux/x86_64
+    ports:
+      - "4000:4000"
+    networks:
+      - databases
+    tmpfs: /var/lib/tidb
+
   vitess-test-5_7:
     image: vitess/vttestserver:mysql57@sha256:53eea9d0189168b51bd8882f3684021fb1fc6bf40c919c18d9d667eded5ffbcb
     restart: always

libs/test-setup/src/mysql.rs

@@ -48,6 +48,10 @@ pub(crate) fn get_mysql_tags(database_url: &str) -> Result<BitFlags<Tags>, Strin
                 if version.contains("MariaDB") {
                     tags |= Tags::Mariadb
                 } else {
+                    if version.contains("TiDB") {
+                        tags |= Tags::TiDB
+                    }
+
                     if version.contains("vitess") {
                         tags |= Tags::Vitess;
                     }

libs/test-setup/src/tags.rs

@@ -40,6 +40,7 @@ tags![
     Postgres13 = 1 << 18,
     CockroachDb221 = 1 << 19,
     CockroachDb222 = 1 << 20,
+    TiDB = 1 << 21,
 ];
 
 pub fn tags_from_comma_separated_list(input: &str) -> BitFlags<Tags> {

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/interactive_tx.rs

@@ -572,8 +572,8 @@ mod interactive_tx {
 mod itx_isolation {
     use query_engine_tests::*;
 
-    // All (SQL) connectors support serializable.
-    #[connector_test(exclude(MongoDb))]
+    // All (SQL) connectors except TiDB support serializable.
+    #[connector_test(exclude(MongoDb, TiDB))]
     async fn basic_serializable(mut runner: Runner) -> TestResult<()> {
         let tx_id = runner.start_tx(5000, 5000, Some("Serializable".to_owned())).await?;
         runner.set_active_tx(tx_id.clone());
@@ -595,7 +595,7 @@ mod itx_isolation {
         Ok(())
     }
 
-    #[connector_test(exclude(MongoDb))]
+    #[connector_test(exclude(MongoDb, TiDB))]
     async fn casing_doesnt_matter(mut runner: Runner) -> TestResult<()> {
         let tx_id = runner.start_tx(5000, 5000, Some("sErIaLiZaBlE".to_owned())).await?;
         runner.set_active_tx(tx_id.clone());
@@ -649,4 +649,39 @@ mod itx_isolation {
 
         Ok(())
     }
+
+    // TiDB supports repeatable read isolation level, but doesn't support serializable isolation level.
+    // Link: https://docs.pingcap.com/tidb/stable/transaction-isolation-levels#tidb-transaction-isolation-levels
+    #[connector_test(only(TiDB))]
+    async fn tidb_basic_repeatable_read(mut runner: Runner) -> TestResult<()> {
+        let tx_id = runner.start_tx(5000, 5000, Some("RepeatableRead".to_owned())).await?;
+        runner.set_active_tx(tx_id.clone());
+
+        insta::assert_snapshot!(
+          run_query!(&runner, r#"mutation { createOneTestModel(data: { id: 1 }) { id }}"#),
+          @r###"{"data":{"createOneTestModel":{"id":1}}}"###
+        );
+
+        let res = runner.commit_tx(tx_id).await?;
+        assert!(res.is_ok());
+        runner.clear_active_tx();
+
+        insta::assert_snapshot!(
+          run_query!(&runner, r#"query { findManyTestModel { id field }}"#),
+          @r###"{"data":{"findManyTestModel":[{"id":1,"field":null}]}}"###
+        );
+
+        Ok(())
+    }
+
+    #[connector_test(only(TiDB))]
+    async fn tidb_casing_doesnt_matter(mut runner: Runner) -> TestResult<()> {
+        let tx_id = runner.start_tx(5000, 5000, Some("rEpEaTaBlErEaD".to_owned())).await?;
+        runner.set_active_tx(tx_id.clone());
+
+        let res = runner.commit_tx(tx_id).await?;
+        assert!(res.is_ok());
+
+        Ok(())
+    }
 }

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/metrics.rs

@@ -32,6 +32,7 @@ mod metrics {
             MongoDb(_) => assert_eq!(total_queries, 5),
             CockroachDb => (), // not deterministic
             MySql(_) => assert_eq!(total_queries, 12),
+            TiDB => assert_eq!(total_queries, 12),
             Vitess(_) => assert_eq!(total_queries, 11),
             Postgres(_) => assert_eq!(total_queries, 14),
         }

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/multi_schema.rs

@@ -1,6 +1,6 @@
 use query_engine_tests::test_suite;
 
-#[test_suite(capabilities(MultiSchema), exclude(Mysql))]
+#[test_suite(capabilities(MultiSchema), exclude(Mysql, TiDB))]
 mod multi_schema {
     use query_engine_tests::*;
 

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/ref_actions/on_delete/set_default.rs

@@ -2,7 +2,7 @@
 use indoc::indoc;
 use query_engine_tests::*;
 
-#[test_suite(suite = "setdefault_onD_1to1_req", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onD_1to1_req", exclude(MongoDb, MySQL, TiDB))]
 mod one2one_req {
     fn required_with_default() -> String {
         let schema = indoc! {
@@ -103,7 +103,7 @@ mod one2one_req {
     }
 }
 
-#[test_suite(suite = "setdefault_onD_1to1_opt", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onD_1to1_opt", exclude(MongoDb, MySQL, TiDB))]
 mod one2one_opt {
     fn optional_with_default() -> String {
         let schema = indoc! {
@@ -206,7 +206,7 @@ mod one2one_opt {
     }
 }
 
-#[test_suite(suite = "setdefault_onD_1toM_req", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onD_1toM_req", exclude(MongoDb, MySQL, TiDB))]
 mod one2many_req {
     fn required_with_default() -> String {
         let schema = indoc! {
@@ -307,7 +307,7 @@ mod one2many_req {
     }
 }
 
-#[test_suite(suite = "setdefault_onD_1toM_opt", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onD_1toM_opt", exclude(MongoDb, MySQL, TiDB))]
 mod one2many_opt {
     fn optional_with_default() -> String {
         let schema = indoc! {

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/ref_actions/on_update/set_default.rs

@@ -2,7 +2,7 @@
 use indoc::indoc;
 use query_engine_tests::*;
 
-#[test_suite(suite = "setdefault_onU_1to1_req", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onU_1to1_req", exclude(MongoDb, MySQL, TiDB))]
 mod one2one_req {
     fn required_with_default() -> String {
         let schema = indoc! {
@@ -105,7 +105,7 @@ mod one2one_req {
     }
 }
 
-#[test_suite(suite = "setdefault_onU_1to1_opt", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onU_1to1_opt", exclude(MongoDb, MySQL, TiDB))]
 mod one2one_opt {
     fn optional_with_default() -> String {
         let schema = indoc! {
@@ -210,7 +210,7 @@ mod one2one_opt {
     }
 }
 
-#[test_suite(suite = "setdefault_onU_1toM_req", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onU_1toM_req", exclude(MongoDb, MySQL, TiDB))]
 mod one2many_req {
     fn required_with_default() -> String {
         let schema = indoc! {
@@ -313,7 +313,7 @@ mod one2many_req {
     }
 }
 
-#[test_suite(suite = "setdefault_onU_1toM_opt", exclude(MongoDb, MySQL))]
+#[test_suite(suite = "setdefault_onU_1toM_opt", exclude(MongoDb, MySQL, TiDB))]
 mod one2many_opt {
     fn optional_with_default() -> String {
         let schema = indoc! {

query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_10935.rs

@@ -1,6 +1,6 @@
 use query_engine_tests::*;
 
-#[test_suite(schema(schema), only(MySql))]
+#[test_suite(schema(schema), only(MySql, TiDB))]
 mod prisma_ref_integrity {
     fn schema() -> String {
         let schema = indoc! {

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/aggregation/group_by_having.rs

@@ -42,7 +42,7 @@ mod aggr_group_by_having {
                 _sum { int }
               }
             }"#,
-            MongoDb(_) => vec![
+            MongoDb(_) | TiDB => vec![
               r#"{"data":{"groupByTestModel":[{"string":"group2","int":5,"_count":{"_all":1},"_sum":{"int":5}},{"string":"group1","int":5,"_count":{"_all":1},"_sum":{"int":5}}]}}"#,
               r#"{"data":{"groupByTestModel":[{"string":"group1","int":5,"_count":{"_all":1},"_sum":{"int":5}},{"string":"group2","int":5,"_count":{"_all":1},"_sum":{"int":5}}]}}"#
             ],

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/batch/in_selection_batching.rs

@@ -35,7 +35,9 @@ mod isb {
     }
 
     // "batching of IN queries" should "work when having more than the specified amount of items"
-    #[connector_test]
+    // Exclude TiDB, TiDB does not guarantee the order of results returned when the `ORDER BY`
+    // clause is not specified
+    #[connector_test(exclude(TiDB))]
     async fn in_more_items(runner: Runner) -> TestResult<()> {
         create_test_data(&runner).await?;
 

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/batch/transactional_batch.rs

@@ -104,7 +104,7 @@ mod transactional {
         Ok(())
     }
 
-    #[connector_test(exclude(MongoDb))]
+    #[connector_test(exclude(MongoDb, TiDB))]
     async fn valid_isolation_level(runner: Runner) -> TestResult<()> {
         let queries = vec![r#"mutation { createOneModelB(data: { id: 1 }) { id }}"#.to_string()];
 
@@ -115,6 +115,18 @@ mod transactional {
         Ok(())
     }
 
+    // TiDB supports repeatable read isolation level, but doesn't support serializable isolation level.
+    #[connector_test(only(TiDB))]
+    async fn valid_isolation_level_tidb(runner: Runner) -> TestResult<()> {
+        let queries = vec![r#"mutation { createOneModelB(data: { id: 1 }) { id }}"#.to_string()];
+
+        let batch_results = runner.batch(queries, true, Some("RepeatableRead".into())).await?;
+
+        insta::assert_snapshot!(batch_results.to_string(), @r###"{"batchResult":[{"data":{"createOneModelB":{"id":1}}}]}"###);
+
+        Ok(())
+    }
+
     #[connector_test(exclude(MongoDb))]
     async fn invalid_isolation_level(runner: Runner) -> TestResult<()> {
         let queries = vec![r#"mutation { createOneModelB(data: { id: 1 }) { id }}"#.to_string()];

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/extended_relation_filters.rs

@@ -90,7 +90,7 @@ mod ext_rel_filters {
     }
 
     // MySql is case insensitive and Postgres case sensitive
-    #[connector_test(only(MySQL))]
+    #[connector_test(only(MySQL, TiDB))]
     async fn mysql_rel1_many_filters(runner: Runner) -> TestResult<()> {
         test_data(&runner).await?;
 

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/having_filter.rs

@@ -39,7 +39,7 @@ mod having_filter {
               string2
             }
           }"#,
-          MongoDb(_) => vec![
+          MongoDb(_) | TiDB => vec![
             r#"{"data":{"groupByTestModel":[{"string":"group1","string2":"group1"},{"string":"group2","string2":"group2"}]}}"#,
             r#"{"data":{"groupByTestModel":[{"string":"group2","string2":"group2"},{"string":"group1","string2":"group1"}]}}"#
           ],

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/field_reference/json_filter.rs

@@ -463,7 +463,7 @@ mod json_filter {
     fn json_path(runner: &Runner) -> &'static str {
         match runner.connector_version() {
             ConnectorVersion::Postgres(_) | ConnectorVersion::CockroachDb => r#"path: ["a", "b"]"#,
-            ConnectorVersion::MySql(_) => r#"path: "$.a.b""#,
+            ConnectorVersion::MySql(_) | ConnectorVersion::TiDB => r#"path: "$.a.b""#,
             x => unreachable!("JSON filtering is not supported on {:?}", x),
         }
     }

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/filter_regression.rs

@@ -5,7 +5,7 @@ use query_engine_tests::*;
 #[test_suite(schema(schema))]
 mod fr_one_to_m {
     use indoc::indoc;
-    use query_engine_tests::run_query;
+    use query_engine_tests::{is_one_of, run_query};
 
     fn schema() -> String {
         let schema = indoc! { "
@@ -65,10 +65,22 @@ mod fr_one_to_m {
           @r###"{"data":{"findManyCompany":[{"id":135}]}}"###
         );
 
-        insta::assert_snapshot!(
-          run_query!(&runner, r#"query { findManyLocation(where: { company: { is: { id: { equals: 135 }}}}){ id }}"#),
-          @r###"{"data":{"findManyLocation":[{"id":311},{"id":314}]}}"###
-        );
+        match runner.connector_version() {
+            ConnectorVersion::TiDB => is_one_of!(
+                run_query!(
+                    &runner,
+                    r#"query { findManyLocation(where: { company: { is: { id: { equals: 135 }}}}){ id }}"#
+                ),
+                vec![
+                    r#"{"data":{"findManyLocation":[{"id":311},{"id":314}]}}"#,
+                    r#"{"data":{"findManyLocation":[{"id":314},{"id":311}]}}"#
+                ]
+            ),
+            _ => insta::assert_snapshot!(
+                run_query!(&runner, r#"query { findManyLocation(where: { company: { is: { id: { equals: 135 }}}}){ id }}"#),
+                @r###"{"data":{"findManyLocation":[{"id":311},{"id":314}]}}"###
+            ),
+        };
 
         Ok(())
     }

query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/filters/json_filters.rs

@@ -111,7 +111,7 @@ mod json_filters {
         Ok(())
     }
 
-    #[connector_test(capabilities(JsonFilteringJsonPath), only(MySql(5.7), MySql(8)))]
+    #[connector_test(capabilities(JsonFilteringJsonPath), only(MySql(5.7), MySql(8), TiDB))]
     async fn extract_json_path(runner: Runner) -> TestResult<()> {
         create_row(&runner, 1, r#"{ \"a\": { \"b\": \"c\" } }"#, false).await?;
         create_row(&runner, 2, r#"{ \"a\": { \"b\": [1, 2, 3] } }"#, false).await?;
@@ -223,8 +223,8 @@ mod json_filters {
         );
 
         match runner.connector_version() {
-            // MariaDB does not support finding arrays in arrays, unlike MySQL
-            ConnectorVersion::MySql(Some(MySqlVersion::MariaDb)) => {
+            // MariaDB / TiDB does not support finding arrays in arrays, unlike MySQL
+            ConnectorVersion::MySql(Some(MySqlVersion::MariaDb)) | ConnectorVersion::TiDB => {
                 insta::assert_snapshot!(
                     run_query!(
                         runner,
@@ -896,7 +896,7 @@ mod json_filters {
     fn json_path(runner: &Runner) -> &'static str {
         match runner.connector_version() {
             ConnectorVersion::Postgres(_) | ConnectorVersion::CockroachDb => r#"path: ["a", "b"]"#,
-            ConnectorVersion::MySql(_) => r#"path: "$.a.b""#,
+            ConnectorVersion::MySql(_) | ConnectorVersion::TiDB => r#"path: "$.a.b""#,
             x => unreachable!("JSON filtering is not supported on {:?}", x),
         }
     }