Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations over WebSocket #5010

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Migrations over WebSocket #5010

merged 15 commits into from
Oct 10, 2024

Conversation

SevInf
Copy link
Member

@SevInf SevInf commented Oct 2, 2024 •
edited
Loading

Internal spec
Close ORM-280

@SevInf SevInf added this to the 5.21.0 milestone Oct 2, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5010 will not alter performance

Comparing accelerate-migration (44fc31a) with main (6a192e2)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.708MiB 2.708MiB 29.000B
Postgres (gzip) 1.036MiB 1.036MiB 27.000B
Mysql 2.035MiB 2.035MiB 0.000B
Mysql (gzip) 812.540KiB 812.541KiB -1.000B
Sqlite 1.928MiB 1.928MiB 0.000B
Sqlite (gzip) 770.435KiB 770.437KiB -2.000B

@SevInf SevInf changed the title [WIP]: Migrations over WebSocket Migrations over WebSocket Oct 8, 2024
@SevInf SevInf marked this pull request as ready for review October 8, 2024 16:04
@SevInf SevInf requested a review from a team as a code owner October 8, 2024 16:04
@SevInf SevInf requested review from jkomyno and removed request for a team October 8, 2024 16:04
SevInf and others added 2 commits October 9, 2024 16:09
@SevInf @jkomyno
Update quaint/src/connector/postgres/native/websocket.rs
2af0f60 
Co-authored-by: Alberto Schiabel <jkomyno@users.noreply.github.com>
@SevInf
Remove dbg
9818106
SevInf added a commit to prisma/prisma that referenced this pull request Oct 9, 2024
@SevInf
feat(client): Support prisma+postgres URL scheme for postgres migrations
5c086a1 
Engine PR: prisma/prisma-engines#5010
Close prisma/team-orm#1297
@SevInf SevInf mentioned this pull request Oct 9, 2024
Merged
SevInf added a commit to prisma/prisma that referenced this pull request Oct 9, 2024
@SevInf
feat(client): Support prisma+postgres URL scheme for postgres migrations
5baa195 
Engine PR: prisma/prisma-engines#5010
Close prisma/team-orm#1297
jkomyno
jkomyno approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after changes ✨

@SevInf SevInf merged commit edd552c into main Oct 10, 2024
368 of 369 checks passed
@SevInf SevInf deleted the accelerate-migration branch October 10, 2024 11:44
SevInf added a commit to prisma/prisma that referenced this pull request Oct 10, 2024
@SevInf
feat(client): Support prisma+postgres URL scheme for postgres migrati…
b11a6c2 
…ons (#25403)

Engine PR: prisma/prisma-engines#5010
Close prisma/team-orm#1297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcan pcan pcan left review comments

@jkomyno jkomyno jkomyno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SevInf @pcan @jkomyno