refactor: mpz-ot #109
Merged
refactor: mpz-ot #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proceeding with merge as this should not introduce security issues, but @themighty1 if you get a time to sanity check where I've touched the coin-toss protocols in CO15 and KOS15 that would be appreciated 🙏 |
sinui0
added a commit
that referenced
this pull request
Apr 30, 2024
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #107 and #108 , refactoring our OT traits and implementations. It also deletes the KOS actor now that we have the
mpz_common::sync::Mutexprimitive 🙏I haven't finished with the committed/verifiable functionalities on the shared KOS variants yet, but will punt that to another PR so we can just move on for now.