refactor(mpz-ot): Normalize OT and ideal functionalities #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
approved these changes
May 6, 2024
It just provides stronger typing and a way to document what each field is. It's better to have the types defined in |
th4s
approved these changes
May 7, 2024
Co-authored-by: th4s <th4s@metavoid.xyz>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <th4s@metavoid.xyz> --------- Co-authored-by: th4s <th4s@metavoid.xyz>
sinui0
added a commit
that referenced
this pull request
Jun 25, 2024
* add transfer id * update co15 and kos15 * add Output type * feat(mpz-common): ideal functionality utils * refactor ideal functionalities and traits * pr feedback * impl ideal rot * Update crates/mpz-ot/src/ideal/rot.rs Co-authored-by: th4s <th4s@metavoid.xyz> --------- Co-authored-by: th4s <th4s@metavoid.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes our OT interfaces as well as completely reimplements our ideal functionality abstraction.
Nothing here touches the security critical logic of any of the OT implementations. This is purely a clean up and testing utilities.
Changes
mpz-ot-coreinstead of leaking intompz-ot.mpz-commonTransferId