Minor fix in M7 #32
Open
Minor fix in M7 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed abstract class definition for Template Method design pattern -- missing abstract in line 331.
XuhuaHuang
reviewed
Nov 8, 2022
| @@ -328,7 +328,7 @@ Let's illustrate the situation with the example of `Figure.draw(Graphics)`, from | |||
| Here the first and last steps *should always happen in the same way*, but obviously the second step will depend on the actual concrete figure. To realize a solution, we capture the first and third steps as private methods in `AbstractFigure` (`BasicFigure` on the diagram). Assume that the code to complete these two operations can be entirely written in the superclass. The code of the `AbstractFigure` class would thus start to look like: | |||
|
|
|||
| ```java | |||
| public AbstractFigure implements Figure | |||
| public abstract AbstractFigure implements Figure | |||
There was a problem hiding this comment.
Shouldn't this be public abstract class AbstractFigure implements Figure ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed abstract class definition for Template Method design pattern -- missing abstract in line 331.
Was not sure if this was intentional or not.