Add the mandr logger to give the user full control over logging #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thomass-dev
commented
Jul 10, 2024
thomass-dev
commented
rouk1
approved these changes
Jul 10, 2024
tuscland
reviewed
Jul 11, 2024
src/mandr/app.py
Outdated
| @@ -83,8 +82,8 @@ def render_top_nav(*args): | |||
| for g in glob | |||
| if g.is_dir() and not g.parts[-1].startswith("_") | |||
| ] | |||
| console.log(f"{links_out=}") | |||
| console.log(f"{path_pairs=}") | |||
| logger.info(f"{links_out=}") | |||
There was a problem hiding this comment.
I would log at debug level here.
src/mandr/app.py
Outdated
| @@ -122,7 +121,7 @@ def home(path): | |||
| if len(path) == 0: | |||
| return render_mander(*[]) | |||
| path_parts = path.split("/") | |||
| console.log(f"{path_parts=}") | |||
| logger.info(f"{path_parts=}") | |||
There was a problem hiding this comment.
As well, I would log at debug level.
| app = Flask(__name__) | ||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
It's quite annoying that they do not respect the usual function naming conventions. Is there a reason to use Rich specifically? I would appreciate an alternative.
There was a problem hiding this comment.
Its not Rich here, its the standard python logging library.
Its usual for the standard libraries in cpython that function respects camel case.
There is no alternative in the logging library to do this with a snake case function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.