-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement a draft JSON API with FastAPI #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rouk1
changed the title
impelment a draft JSON API with FastAPI
implement a draft JSON API with FastAPI
Jul 11, 2024
adrinjalali
reviewed
Jul 11, 2024
thomass-dev
reviewed
Jul 11, 2024
tuscland
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good minimalistic starting point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new webapp is now available in the
src/mandr/dashboard
package.In
src/mandr/dashboard__init__.py
a helper function is available to launch a dashboard from the notebook.It will start an async task that serves HTTP requests in the background.
You may also run the webapp in it's dedicated interpreter by running:
python -m uvicorn mandr.dashboard.webapp:app --reload --host 0.0.0.0 --timeout-graceful-shutdown 0
Two JSON endpoints have been implemented:
GET /mandrs
to list all existing mandrs path below the root project folderGET /mandrs/{path}
to get a JSON serialized mandr (http://localhost:8000/mandrs/probabl-ai/demo-usecase/training/0)This first step opens the possibility to write a static JS webapp that consumes this API.
It also raises some questions ❓ :
JSONInfoManderEncoder
powerful enough ?