feat: Adapt skore to be compliant on python >=3.9, <3.13
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thomass-dev
commented
Oct 10, 2024
•
thomass-dev
commented
- Remove requirements files
- Remove use of requirements in Makefile and CI
- Add support of python 3.9 and 3.10
- Fix code and tests
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
3 times, most recently
from
08d7551
to
64a499a
Compare
thomass-dev
changed the title
python >=3.9python >=3.9, <3.14
thomass-dev
changed the title
python >=3.9, <3.14python>=3.9,<3.14
thomass-dev
changed the title
python>=3.9,<3.14[3.9, 3.14[
thomass-dev
changed the title
[3.9, 3.14[python >=3.9, <3.14
thomass-dev
changed the title
python >=3.9, <3.14python >=3.9, <3.13
thomass-dev
changed the title
python >=3.9, <3.13python >=3.9, <3.13
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
from
64a499a
to
0eac73c
Compare
|
How hard is it to support 3.13? |
rouk1
requested changes
Oct 10, 2024
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
3 times, most recently
from
c82f211
to
c8d8aed
Compare
thomass-dev
changed the title
python >=3.9, <3.13python >=3.9, <3.14
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
2 times, most recently
from
7b6c833
to
2c7dfe7
Compare
Vega is not compatible vega/altair#3620 vega/altair#3587 😢 . |
thomass-dev
changed the title
python >=3.9, <3.14python >=3.9, <3.13
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
3 times, most recently
from
d1e0abc
to
7ed4d4a
Compare
thomass-dev
force-pushed
the
390-adapt-skore-to-be-compliant-on-python-39
branch
from
7ed4d4a
to
22f26cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.